Reviewing merge request #119: Nanno playlist: performance change A (fewer notifyObservers)

Let SqlTrack batch metadata updates into 1 notifyObservers() call.

This helps playlist performance because each metadataChanged() call becomes a Qt dataChanged() signal in PlaylistModel.cpp, which then forces SortProxy to do re-sort work and GroupingProxy to do re-group work.

This commit must be verified by someone who knows SqlMeta.cpp well.

Requested by: Nanno Langstraat
Status: Merged
Source repository: nanno-playlist-work:nanno-pl-performance-A
Target repository: amarok:master
Created at: February 11th, 2010 09:56

Commits that would be merged:

Version 1

Version 1

4a67e0d
3617b37

Playlist performance: let SqlTrack::finishedPlaying() do only 1 notifyObservers().

Showing

Showing 4a67e0d-3617b37

Comments
Include comments entered inline

→ State changed from Open to Merged

Makes sense, merged.

Maximilian Kossick | 2010-02-21 16:32:34 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/119

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/amarok/amarok.git \
  refs/merge-requests/119

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/119

# To apply the changes to your branch:
git checkout master
git merge merge-requests/119
git push origin master

Reviewing merge request #119: Nanno playlist: performance change A (fewer notifyObservers)

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline