Reviewing merge request #132: tidy up playlist toolbar

moves around the buttons
screenshot:
http://img697.imageshack.us/img697/1718/amaroktidy.jpg

(the "show current track" button is only visible with the slider)

i know that the "playmode" button was hard to find for several ppl, probably for the icon and the unfortunate position.

i think this position is better, but we'd also make ppl. research it :-\

Commits that would be merged:

Version 1
  • Version 1
  • 6c92069
  • e18b42f
  • re-sort playlist toolbar

Showing 6c92069-e18b42f

Comments

i dont know about this layout. maybe it was hard to find, but now i think it’s even harder to find :P

I think this is useful. Especially like the show active track underneath the scrollbar.

Thomas: can you make a screenshot with a standard panel layout?

Only to be merged after 2.3 is tagged though. There is to much change in that version already.

@Leo:
The idea was that the playmode as well as the playlist sorting impact play order. Thus they shold be related, thus… ;–)
(tbh. i think the main flaw is the weak icon for straight playback – not that i knew a better one, though =)

@Bart:
Do you mean the “Media Source | Context | Playlist” layout or the spacings in the bar below the playlist?

→ State changed from Open to Verifying

I tend to agree with Leo, for the moment.

@Thomas: Not using a standard (default) layout and style makes it very confusing to judge your screenshots.

sorry, the shot was rather intended to illustrate the description (what’s placed where)

However – testing with the oxygen style the current implementation cannot be used visually (i wasn’t aware that there’re toolbutton frames -more frames- if the parent() isn’t QTooBar, sorry…)

So i’ll have to alter the implementation (maybe i generalize the buttonclass for the current track info)

—> MARKED AS PENDING
(gitorious lacks this ;-P

→ State changed from Verifying to Rejected

Ok, for now I’ll simply change it to “Rejected” then.

I guess it would be best to make a new MR if you come up with another patch.

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository