Reviewing merge request #133: (SlideTimer): code cleanup and RtL support

this cleans up the slider a bt and makes it rtl capable

done:
-------
- right-to-left support for the custom slider
- !!! VISUAL change: don't draw a custom knob if disabled (it's currently only used and relevant for the timeslider. this stresses "you cannot drag" while playing streams)
- moodbar swapping
- some code cleanup, notably
* the weird "adjustedValue()" thing is gone. the inversion is handled by a flag and not by swapping around values ;-)
* use QStyleOptionSlider for painting. It keeps req. state flags.

"to do":
--------
- svg sking completion:
the RTL slider needs an additional svg element (counterpart of the sliderstart)
as merging the svg is pretty nasty and i forsee a change on the skip icons, i'll preferably do that from master as soon as and in case this is merged ;-)

Commits that would be merged:

Version 1
  • Version 1
  • aafc476
  • 37cb4f5
  • amarok::slider, rtl capability/awareness; code stripping/sanification

Showing aafc476-37cb4f5

Comments

+1 from me, i like the no-knob-on-non-seekable-tracks

→ State changed from Open to Verifying

Going to try this here.

→ State changed from Verifying to Merged

Looks good to me too. Merged.

Thanks Thomas :)

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository