Reviewing merge request #134: Add embedded cover art support
Simple, non-intrusive patch to include images from id3v2 APIC frames to the collection's cover arts.
During the collection-scanning process, APIC frames are detected in the audio files and included via an additional attribute apic="true" in the corresponding <tags/> tag.
Upon processing of the scan result, the paths of the audio files with the apic flag set are added to the images table just like normal cover arts (folder.jpg,...). If both types of cover arts are available for an album, non-embedded ones take precedence.
Whenever an image would be loaded from the file, a check is made whether it is an embedded one or not. If so, loadImageFromTag() extracts the picture via Taglib and returns it. Image-caching keeps working as expected.
- Requested by:
ecroy - Status: Closed
- Source repository: ecroys-amarok:embedded_coverart
- Target repository: amarok:master
- Created at: February 26th, 2010 01:16
Commits that would be merged:
Comments
Looks good to me :)
Going to try this here.
would be nice if max and jeff could comment—-specifically if max has any issues with adding taglib/mp3 code to sqlmeta.
Thanks Andreas, merged :)
Please also see comments from Dan Meltzer on the amarok-devel mailing list.
Due to revert, I'm changing the status of this MR accordingly.
Andreas, any interest in fixing it up as discussed on the mailing list so we can merge? :)
Bump. Many people would really like to see this get into trunk.
I also want to see this fix.
Small improvement proposal:
Check the type of the APIC and only consider album covers and not just every attached picture.
Ralf, we are waiting for feedback from the requester, so not much we can do about this.
Again, Andreas, please could you answer our request?
Already implemented for mp3, please follow the discussion on amarok-devel@kde.org
Add a new comment:
Login or create an account to post a comment