Reviewing merge request #135: Make trackFinished its own event in EngineObserver so it is meaningful in scripts (227312)

The EngineObserver facility was refactored in the change from 2.1 to 2.2. In the process, the trackFinished() event in scripting, which used to fire when a track finished (and not when a track was changed just by skipping or selecting another) was changed to fire only at the end of a playlist. This was pretty useless. This issue is tracked by bug 227312. This change updates EngineObserver to follow trackFinished separately again-- it is kicked off by EngineController::slotAboutToFinish.

Commits that would be merged:

Version 1
  • Version 1
  • 0475d89
  • edbd032

    • Make trackFinished its own event in EngineObserver

  • d924448

    • Change tab to spaces in keeping with standards

Showing 0475d89-edbd032

Comments

looks good to me, i'm for merging. will test tomorrow.

avatar Leonardo Franchi | 2010-03-04 04:38:08 UTC

→ State changed from Open to Verifying

Looks good to me as well, testing now.

avatar Mark Kretschmann | 2010-03-17 07:38:01 UTC

→ State changed from Verifying to Merged

Thanks, I've merged your patch into mainline :)

avatar Mark Kretschmann | 2010-03-17 07:50:36 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository