Reviewing merge request #137: Don't fail silently when the wallet isn't available

Currently, if KWallet is available when Amarok is first run by a user, and subsequently disappears, scrobbling fails because the username and password cannot be found. Worse: if the user re-enters the username and password, it is simply discarded with no explanation.

This asks the user if they want to store the username and password in the config file in this case.

Commits that would be merged:

Version 1
  • Version 1
  • e9c6052
  • 862ac2c

    • Don't fail silently when the user has asked to use the wallet, but it

Showing e9c6052-862ac2c

Comments

Note: I created the merge request (rather than just committing) because I haven’t actually tested that it does what it says yet. So if you want to test the fix, do so. Otherwise, you can just wait for me to test it.

avatar Alex Merry | 2010-03-04 01:10:42 UTC

+1 from me

avatar Leonardo Franchi | 2010-03-04 03:09:14 UTC

→ State changed from Open to Merged

I merged in a better (properly working) version, and fixed a couple of other quirks while I was at it.

avatar Alex Merry | 2010-03-04 23:34:15 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository