Reviewing merge request #6: added multi-page result support (one webview)

This implementation only uses one webview, to reduce memory consumption.

Commits that would be merged:

Version 1
  • Version 1
  • e210e58
  • 389b402

    • Adding support for multiple page results, with one webview

Showing e210e58-389b402

Comments

Pushed new version 1

avatar Amit Singh | 2012-01-11 17:57:36 UTC

Looking very good!!

I’ll try to get it merged tomorrow :–)

avatar Simón Pena | 2012-01-11 22:34:53 UTC 

+     m_showtimesBaseUrl = QUrl("http://www.google.com/movies");

I'm calling m_movies.clear() here. That way, if you check movie showtimes in two different locations, only the right movies are shown.

avatar Simón Pena | 2012-01-12 22:44:38 UTC on src/theatershowtimesfetcher.cpp 

+     m_showtimesBaseUrl = QUrl("http://www.google.com/movies");

Also, instead of the static int numCalled, I used a member m_parsedPages, which I clear at the same time as the m_movies one. That way, you can check movie showtimes multiple times.

Although I mention these comments here, you don’t need to update the merge request: they were small modifications and I already did them myself.

avatar Simón Pena | 2012-01-12 22:46:43 UTC on src/theatershowtimesfetcher.cpp

→ State changed from Open to Closed

Thanks! I've merged this into master, and it’ll be available in the next release.

avatar Simón Pena | 2012-01-13 09:05:05 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository