Reviewing merge request #7: Highlight next episode if it was in the past
This change will highlight (bold text) series that have next episodes which have already aired. This way you can easily see if a serie has an episode that you have missed.
This is my first android patch, so I might have taken the most straightforward/brain dead approach instead of the best approach. It's a small patch though and should be save (Works for me)
- Requested by:
BlackEdder - Status: Merged
- Source repository: blackedders-droidseries:master
- Target repository: droidseries:master
- Created at: October 9th, 2011 13:44
Commits that would be merged:
Comments
Pushed new version 1
I just noticed that this “partly” addresses issue 10
Thanks for your contribution. I'm currently working on three critical bugs. I’ll release this patch with the bug fixes on the next version.
Let me know if you want to code some more, I’ll probably have some pointers for you or you can just help me fix the current bugs :)
Dear Paulo,
Thank you for merging the patch. I am afraid I might already have noticed a bug, where when the main window is rotated all Next episodes are in bold. Probably the solution is to specifically set the textView to not bold if the episode has not been aired yet. I can probably do this tonight (it is now morning here) or otherwise tomorrow night.
If the fact that my first patch already was buggy doesn’t discourage you too much then I would be willing to help (time permitted). Which bugs are you looking at (issue numbers?). Since I don’t really have an overview over the code as a whole yet, it would probably easiest for me to work on a bug that only affects a small part/reasonably independent part of the code.
Cheers,
Edwin
Add a new comment:
Login or create an account to post a comment