Reviewing merge request #5: Command-line parser
Added an actual command-line parser to dcaenc. Also added a number of useful options.
(Note: I use "xgetopt" for MSVC compatibility, as it has no getopt)
Commits that would be merged:
- 720af20
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
720af20-0d029b8Comments
Pushed new version 1
Hi. I think I will merge all your changes that are not specific to Windows and to which I don’t have a better replacement. On the other hand, I don’t want to have Windows-specific parts of code in my repository, because I cannot test or review them properly.
So how about the following plan:
I add a link to your fork to the README and recommend your fork to Windows users.
You remove all linux-specific code, e.g. the whole alsaplugin.c file and the corresponding documentation in the README. You may want to remove the autoconf-based buildsystem altogether.
You modify your copy of the README so that it recommends my fork to non-Windows users.
OK?
Thank you.
Nevertheless I would prefer to merge everything, instead of having to maintain+sync two forks.
Some points:
The Windows-specific changes shouldn’t effect Linux build at all (again: That I removed ALSA from Autoconf was only to workaround a local build issue and should never be merged). At least I ensured my modified version will still build with GCC under MinGW. So it probably does build under Linux too. If not, I would prefer to fix that. All the Windows-specific files, like “config_msvc.h” and “vc_solution” can safely be ignored by Linux users. So merging those shouldn’t be a big deal.
We need to keep in the Autoconfig stuff (maybe even ALSA support), because even under Windows some people may want to build with MinGW/GCC. In my test the GCC build runs much faster than MSVC! You can use ICL with Visual Studio, which gives GCC-like speed, but not everybody has ICL installed…
The fewer differences between your “official” version and my modified version, the easier it will be to back-port your future improvements and fixes :–)
Best Regards,
MuldeR.
OK, I will try to merge this a bit later in chunks I am comfortable with.
Okay, thank you.
Please note that I fixed a bug in my code 5 minutes ago.
Regards,
MuldeR.
Superseded by a later request, closing.


Add a new comment:
Login or create an account to post a comment