Reviewing merge request #2: Two issues concering Services

Hi,
I just started playing with the fastcgiqt library and had two issues concering Services. These two changes fixed it for me.

Thanks for your work..

Requested by: nmandery
Status: Open
Source repository: nmanderys-fastcgiqt:BigChanges
Target repository: fastcgiqt:BigChanges
Created at: June 5th, 2010 15:54

Commits that would be merged:

Version 1

Version 1

13210f7
4147643

fixed scope of parameters variable

d424a77

removed whitespace between slot parameters, as this messes up the correlation the slots of the class in Service.cpp

Showing

Showing 13210f7-4147643

Comments
Include comments entered inline

Sorry for the delay; first diff doesn’t compile for me (and I can’t see an earlier definition of parameters), second appears to be unneccessary (works for me), could you please provide a testcase?

Fred Emmott | 2011-01-03 11:57:56 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/2

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/fastcgiqt/fastcgiqt.git \
  refs/merge-requests/2

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit BigChanges..merge-requests/2

# To apply the changes to your branch:
git checkout BigChanges
git merge merge-requests/2
git push origin BigChanges

Reviewing merge request #2: Two issues concering Services

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline