Commit 34f7ed1fc76dbbcd8f2984d4304ec24ead244b43

Fix some rare or minor issues found with Clang 2.7 analyzer.


422	422	#define NUM_ZERO(n) ((n) < 0)
423	423	#define NUM_SPECIFIED(n) ((n) != 0)
424	424
425		#define MULTIDROP(ctl) (ctl->wildcard \|\| \
426		((ctl)->localnames && (ctl)->localnames->next))
	425	#define MULTIDROP(ctl) ((ctl)->wildcard \|\| \
	426	((ctl)->localnames && (ctl)->localnames->next))
427	427
428	428	/*
429	429	* Note: tags are generated with an a%04d format from a 1-origin


514	514	}
515	515
516	516	sin = (struct sockaddr_in *)info.rti_info[RTAX_NETMASK];
517		if (!sin)
	517	if (sin)
518	518	{
519	519	ifinfo->netmask = sin->sin_addr;
520	520	}
…	…
524	524	* of non point-to-point link
525	525	*/
526	526	sin = (struct sockaddr_in *)info.rti_info[RTAX_BRD];
527		if (!sin)
	527	if (sin)
528	528	{
529	529	ifinfo->dstaddr = sin->sin_addr;
530	530	}


649	649	int n, oldphase;
650	650	char *last;
651	651
	652	if (!buf)
	653	return -1;
	654
652	655	/* The line may contain NUL characters. Find the last char to use
653	656	* -- the real line termination is the sequence "\n\0".
654	657	*/


1238	1238	for (idp = msgblk.recipients; idp; idp = idp->next)
1239	1239	if (idp->val.status.mark == XMIT_ACCEPT)
1240	1240	break; /* only report first address */
1241		snprintf(buf+1, sizeof(buf)-1,
1242		"for <%s>", rcpt_address (ctl, idp->id, 1));
	1241	if (idp)
	1242	snprintf(buf+1, sizeof(buf)-1,
	1243	"for <%s>", rcpt_address (ctl, idp->id, 1));
1243	1244	snprintf(buf+strlen(buf), sizeof(buf)-strlen(buf)-1,
1244	1245	" (%s); ",
1245	1246	MULTIDROP(ctl) ? "multi-drop" : "single-drop");