Reviewing merge request #132: uninitialised variables cause errors on first call.

Some users see nil values during initialisation, this causes an error. Set variables to some value or test for nil.

This update is un-tested, as I'm not near my computer.

Commits that would be merged:

Version 3
  • Version 1
  • Version 2
  • Version 3
  • e01bb50
  • 6ae4a9c

    • uninitialised variables have nil values during first call.

  • 9d0d195

    • experimental use of un-committed merge request removed.

  • 585617d

    • Merge branch 'master' of git://gitorious.org/fg/fgdata into V2.6.0_2

  • 9fcef39

    • missing semicolon.

Showing e01bb50-6ae4a9c

Comments

Pushed new version 1

avatar Scott | 2012-01-17 00:09:41 UTC

Were you able to test it in the mean time? It’s rather “unconvenient” to commit stuff that no-one tested (I don’t know what to test for…).

avatar Gijs | 2012-01-23 18:08:06 UTC

Pushed new version 2

avatar Scott | 2012-01-24 12:43:54 UTC

Hi ya Gijs,

This was because you mentioned that you had Nasal errors on the previous merge request.
I was unable to reproduce those errors (??).
So these are my best guess of what could cause any Nasal errors looking at the terminal output you posted, which has file and line-numbers in it.

So I can’t test it, because I never saw the error, but it also falls into general clean-up of code.

So the only test is if you see any Nasal errors remaining with this patch?

S.

avatar Scott | 2012-01-24 12:51:07 UTC

Sorry for the late reply, been bussy. I though Stuart was the one that reported the Nasal errors, but apparently I saw them too :P

Anyway, I still get errors:

Nasal parse error: parse error in C:/FlightGear/fgdata/Aircraft/A380/Nasal/system.nas, line 512
Door system ready
Initialising Flight Guidance V1.1.9
Airbus Auto Flight Control 2.0.4
Nasal runtime error: nil used in numeric context
at C:/FlightGear/fgdata/Aircraft/A380/Nasal/Airbus_fg.nas, line 1388
called from: C:/FlightGear/fgdata/Aircraft/A380/Nasal/Airbus_fg.nas, line 2242
Init FMS V2.0.3
Nasal runtime error: No such member: fms
at C:/FlightGear/fgdata/Aircraft/A380/Nasal/mcdu.nas, line 134
Init FMS V2.0.3
Nasal runtime error: No such member: fms
at C:/FlightGear/fgdata/Aircraft/A380/Nasal/mcdu.nas, line 134

avatar Gijs | 2012-01-29 20:51:20 UTC

Pushed new version 3

avatar Scott | 2012-01-31 09:02:37 UTC

→ State changed from Open to Closed

Pushed. At least the Nasal errors are gone now. Still a lot of other errors to go though…

avatar Gijs | 2012-02-05 11:28:33 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository