Reviewing merge request #97: New XML-based CDU system
This commit replaces Gijs' original Nasal-based CDU with a new XML-based system. Documentation can be found inside.
The following aircraft have been changed to support the new system:
* 717
* 747-400 (upstream change required)
* 757-200
* 777-200ER (upstream change required)
* A320 (upstream change pending)
* CRJ900
Obviously, please wait for review by Gijs.
Commits that would be merged:
Comments
Currently I'm “neutral” in this matter. There are some nice aspects in Ryan’s upgrade, but also some things that I liked more in my original system.
Before it is commited at all I'd also like to know the status of Claus' (hcc23) CDU system. There’s no need to commit several variants to Git within the same week/month, as we know aircraft-authors aren’t eager to implement things that change frequently ;)
Other opinions on the CDU system are warmly welcomed!
Oh dear – did we ever have two competing merge requests at the same time? ;–) At least seems like a very good sign of FG activity…
I'm looking into some (performance) issues with the other CDU system anyway. I’ll also look at this one.
Gijs, can you have closer look at both CDUs (i.e. functionality)?
Hi Ryan (and others),
I am the author of the “competing” CDU (a Nasal based approach), although I certainly don’t see any competition here as both approaches are publicly available and people can pull what they like :)
I just wanted to throw in my 2c here:
“My” system is currently “ready” (see disclaimer in my merge request and below) to be merged. However, as it is Nasal based, it might create some performance drawback (which I can’t really judge) – Thorsten B. gladly volunteered his time to investigate.
As such a XML based system might be much faster in displaying.
I also need to state that my commitment to FG will significantly drop after my work project has finished (after which I will only be a casual user/developer), so if you don’t like the Nasal framework (which is NOT the pages!) and don’t think I can change it within the next couple of weeks, go with the XML as I most likely won’t be able to work much on the framework after that time. (Coding pages is different, that I consider doable by the casual Nasal coder – if it isn’t the (Nasal) framework is flawed and in that case – if the XML framework is easier for the casual XML page coder – I'd say go with the XML.)
Ryan,
my XML is absolutely horrible (never really got the jist of the language), so if you have XML code that deals with the different font sizes (particularly in one row/line), could you please point that code out to me so that I could copy that over into my Nasal based approach? (I haven’t been able to get that working, which is a big draw back.) Thanks a lot.
Claus
Okay, pushed an update by Thorsten B. Unfortunately, a merge got caught between that commit and the original. Only rebase commits 74a06a6 and 790cce6, NOT the merge.


Add a new comment:
Login or create an account to post a comment