Reviewing merge request #1: show animated gifs, zoom images to window size
Hi,
could you have a look whether you look these changes?
I think the zooming should be optional, but I had to get a train ticket usable for tomorrow morning, so I didn't put it in a menu action.
Let me know what you think
- Requested by:
Simon Schubert - Status: Open
- Source repository: corecodes-fmms:master
- Target repository: fmms:master
- Created at: February 3rd, 2011 01:45
Commits that would be merged:
Comments
Hey, thanks for the MR.
For image zooming, imo this is possible for the user to do in the Photos application instead.
Is there a nicer way to check if the image should be animated then wrapping the PixbuxAnimation stuff in a try/catch? :)
The PixbufAnimation will also work for still images. I just put it in a try/catch to make sure that I wouldn’t remove some functionality.
I never managed to zoom images in the photo app, and the photo app also didn’t show anymated images for me.
For me, the zooming is more important than the animation, because a microscopic QR code will just not work for a train ticket check.
Add a new comment:
Login or create an account to post a comment