Reviewing merge request #1243: Made some improvements for private mode support in gitorious: Removed regi...
Made some improvements for private mode support in gitorious:
Removed registration buttons in second generation design and replaced them by send mail to site_admin. Site_admin can be configured in config file.
- Requested by:
Thomas Schamm - Status: Rejected
- Source repository: tschamms-private-mode-fix:master
- Target repository: mainline:master
- Created at: August 15th, 2009 10:36
Commits that would be merged:
- 4b7c97d
- 3f2be4e
private mode changes: removed registration buttons in second generation design, replaced them by send mail to site admin button
4b7c97d-3f2be4eComments
Hi Thomas,
What’s the values for server_admin_emails? You have not set a default value for it, and I also don’t see the setting being used anywhere. Am I missing something here?
Christian
Hi Christian,
for private mode, this mr disabled the option to register as a new users. Instead, a participation request may be sent to the mail address given by server_admin_emails. See app/views/layouts/second_generation/application.html.erb line 22 and 51.
Regards, Thomas
Ah, so it’s just a mailto link? I kinda expected Gitorious to send the email, but I guess the mailto link is ok. Mind rebasing against master so the patch applies cleanly?
This MR is out of date – there is no registration button anymore in private mode. Thanks anyway.
Add a new comment:
Login or create an account to post a comment