Reviewing merge request #2208: Make grit ignore tags pointing to blobs
Albeit unusual, it is possible to have a tag that points directly to a blob. Ignore such tags when creating the list of available tags (which point to commits) instead of raising an error.
- Requested by:
Peter Kjellerstedt - Status: In Review
- Source repository: saurs-mainline:ignore_blob_tags
- Target repository: mainline:master
- Created at: March 8th, 2010 15:56
Commits that would be merged:
Comments
Rebased to apply cleanly to the current state of Gitorious.
Rebased against current master.
Rebased against current master.
We will be removing the push_event_processor very soon; we will no longer be creating separate events for each commit (this really hurts our database) and the readability/testability of that processor was really bad.
The new processor is in the remove-commit-events branch, and the new processor is in http://gitorious.org/gitorious/mainline/blobs/remove-commit-events/app/processors/push_processor.rb
Also: is it possible to provide some tests for the grit stuff?
Updated to apply to current master. As the push_event_processor has been removed the only thing left is the changes to grit to make it ignore tags to blobs.
The previous patch made Gitorious not create events for tags to blob as well. However, I am not sure if that is the right thing to do or not, so I did not implement it in the new push processor. Tags to blobs are shown just like normal tags, but the link will of course not work as expected, and Gitorious just reports that the SHA1 is not a valid tree (which it isn’t).
Add a new comment:
Login or create an account to post a comment