Reviewing merge request #86: Correct executability test for the pre-receive hook

Commits that would be merged:

Version 7
  • Version 1
  • Version 2
  • Version 3
  • Version 3
  • Version 4
  • Version 5
  • Version 6
  • Version 7
  • 0aec325
  • ec2ccd4
  • Correct executability test for the pre-receive hook

Showing 0aec325-ec2ccd4

Comments

The problem was that File.readlink(filename) may return a relative path, which is then relative to dirname(filename) rather than the current directory, so the test for executability fails since this is not taken into account. However, File.executable?() will do the right thing regarding symbolic links automatically so there is no need to try to be clever.

Rebased to apply cleanly to the current state of Gitorious.

Rebased against current master.

→ State changed from Open to Merged

The only thing that’s better than deleting code is having other people delete your code.

This is some high octane code, thanks!

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository