Reviewing merge request #6: Fix potential string buffer overflow.

Commit fc391f802 introduced a bug in this function, as the strncpy() doesn't put a terminating NULL if the copied string is longer then the provided buffer length. Allocating the buffer as 1 byte longer will ensure that there is a NULL at the end (calloc() fills the buffer with NULLs).

Requested by: Krzysztof Nowicki
Status: Closed
Source repository: krissn-initng:master
Target repository: initng:master
Created at: December 19th, 2009 15:36

Commits that would be merged:

Version 1

Version 1

a2e6970
a4f3a3b

strncpy() doesn't put a terminating NULL if len > n

Showing

Showing a2e6970-a4f3a3b

Comments
Include comments entered inline

→ State changed from Open to Closed

Merged. Great find ;).

Ismael Luceno | 2009-12-22 08:09:42 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/6

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/initng/initng.git \
  refs/merge-requests/6

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/6

# To apply the changes to your branch:
git checkout master
git merge merge-requests/6
git push origin master

Reviewing merge request #6: Fix potential string buffer overflow.

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline