Reviewing merge request #13: Support for Wildcard Realm

Fixes #45, adds support wildcard hosts in two different ways:

- Using "*" will add a wildcard to the current domain
- Using "*.domain" use a wildcard for the trustRoot and "domain" for the returnUrl

When applying a wildcard "*" on a subdomain (eg: www.example.com) could have unexpected results (eg: *.www.example.com). This could also happen the other direction, for example "*.example.com" when on "www.example.com" will result in a returnUrl of "example.com".

These commits do not address these issues, but do fix issue #45.

Requested by: Woody Gilk
Status: Open
Source repository: lightopenid-development:master
Target repository: lightopenid:master
Created at: December 2nd, 2011 21:27

Commits that would be merged:

Version 1

Version 1

97e71eb
e351461

Add support for guessing the $host in LightOpenID::__construct()

71614f6

Add support for using wildcard hosts in LightOpenID::__construct(), $host can be "*" or "*.domain"

Showing

Showing 97e71eb-e351461

Comments
Include comments entered inline

Pushed new version 1

Woody Gilk | 2011-12-02 21:27:30 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/13

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/lightopenid/lightopenid.git \
  refs/merge-requests/13

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/13

# To apply the changes to your branch:
git checkout master
git merge merge-requests/13
git push origin master

Reviewing merge request #13: Support for Wildcard Realm

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline