Reviewing merge request #2: Odd EXIF data with timezones have been fixed.

We came across a set of files that also specifies a timezone in their datetimeoriginal field. This broke the Regex in parse_line (it then happily returned the date as a string).

I extended the regex and added a "broken" jpg along with a unit test.

Requested by: ccoenen
Status: Merged
Source repository: mini_exiftool_ccoenen:master
Target repository: mainline:master
Created at: March 2nd, 2011 15:39

Commits that would be merged:

Version 1

Version 1

437d078
4f53568

added timezone-support to date conversion. timestamp in the form of yyyy:mm:dd hh:mm:ss +zz:zz will automatically use DateTime Class

efdcf3b

added a test for this patch

Showing

Showing 437d078-4f53568

Comments
Include comments entered inline

→ State changed from Open to Merged

Bug is fixed in version 1.2.0. Thanks for your hint and patch. I solved the issue a little bit different.

janfri | 2011-03-15 09:28:40 UTC

Thanks for the fix, I am glad i could help.

ccoenen | 2011-03-15 09:31:31 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/2

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/mini_exiftool/mainline.git \
  refs/merge-requests/2

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/2

# To apply the changes to your branch:
git checkout master
git merge merge-requests/2
git push origin master

Reviewing merge request #2: Odd EXIF data with timezones have been fixed.

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline