Reviewing merge request #22: UpdaterService

This is ready for some more extensive testing now. There is still no auto background call to the service, but it shouldn't be too far off. I've not looked into it though. I've also deleted a lot of code in PonyExpressActivity.java because now that we are using a service, updates should not need to be resumed. Also, I set the copyright to you. If that is a problem, let me know.

Commits that would be merged:

Version 2
  • Version 1
  • Version 2
Showing 4953c90-f821bdd

Comments

Pushed new version 1

avatar Jamie Daws | 2012-02-15 02:22:31 UTC

Great stuff Jamie!

It works really well, and I love that you've broken it up in to lots of methods, it is really readable.

The only thing I would like you to change is the copyright assignments as I mentioned before. Can you change them to Copyright 2012 Jamie Dawes?
I would like the credit to be yours as I didn’t do anything :–)

Thanks,
Paul

avatar Paul Elms | 2012-02-20 11:16:42 UTC

Pushed new version 2

avatar Jamie Daws | 2012-02-20 18:12:37 UTC 

I changed the copyright of UpdaterService and ReturnCodes to me.  I certainly like be fair, but my priority is the health of the project.  Although, the more I think about it, there shouldn't be any problems with me having a copyright.

avatar Jamie Daws | 2012-02-20 18:21:34 UTC

→ State changed from Open to Closed

Thanks Jamie,
I have merged your code in.

avatar Paul Elms | 2012-02-21 09:52:21 UTC

Thanks Paul!

avatar Jamie Daws | 2012-02-21 12:03:50 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository