Reviewing merge request #15: Allow specifying the full module name for extensions.

Before this patch, it was possible to pass a list of extensions and parameters to use when instantiating a new Markdown instance, but it was not possible to give a full module name; the extension had to be a submodule in markdown.extensions.

Now we allow giving a full module path, to make it easy to use custom extensions which are not bundled within the markdown package. The previous behaviour has been retained when there is no '.' in the extension name.

This is very interesting for some projects which provide very specific extensions which would not make sense in python-markdown itself.

Commits that would be merged:

Version 1
  • Version 1
  • ef7b35a
  • 8e96e6f

    • Allow specifying the full module name for extensions.

Showing ef7b35a-8e96e6f

Comments

Pushed new version 1

avatar Steve Frécinaux | 2011-11-01 22:16:03 UTC

Steve,

Thought you might like to know that the code here in Gitorious is a little old. Development has been happening on Github lately.

In any event, interesting patch. But I have to ask, how is this better than the mdx_modulename solution we already have? Or more specifically, what can this do that that can’t?

I should also note that we are currently in a beta release so we won’t be adding any new features – only bug fixes. Perhaps we’ll consider your request after 2.1.0-final is released.

avatar Waylan Limberg | 2011-11-02 14:29:41 UTC

Well, with this patch you can use fully-qualified module names which lie in your own module rather than polluting the python root. Better for self-containment.

Also you can consider this as a bugfix ;–)

avatar Steve Frécinaux | 2011-11-02 14:33:26 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository