Reviewing merge request #9: Use numerical sort for Seasons

if you have a show with more than 10 seasons, listing the seasons shows something like:

Season 1
Season 10
Season 2
Season 3
...

This happens because seasons are stored as strings, so when comparing in the sort function, "10" is smaller than "2".

The current request changes the sorting function, so in the comparison it takes the seasons as integers. Thus, it shows the seasons correctly

Season 1
Season 2
....
Season 9
Season 10

Requested by: Juan A. Suárez Romero
Status: Closed
Source repository: jasuarez-seriesfinale:sort
Target repository: seriesfinale:master
Created at: November 6th, 2011 01:14

Commits that would be merged:

Version 1

Version 1

28323e2
b02e76b

Sort seasons by numerical comparison

Showing

Showing 28323e2-b02e76b

Comments
Include comments entered inline

Pushed new version 1

Juan A. Suárez Romero | 2011-11-06 01:14:50 UTC

→ State changed from Open to Closed

Pushed as b02e76ba1e0dd876742a4d2ac28044eb77c87f52.

Juan A. Suárez Romero | 2012-01-18 23:17:41 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/9

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/seriesfinale/seriesfinale.git \
  refs/merge-requests/9

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/9

# To apply the changes to your branch:
git checkout master
git merge merge-requests/9
git push origin master

Reviewing merge request #9: Use numerical sort for Seasons

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline