Reviewing merge request #1184: Notice patrol: two variables $public and $system were generating notices in...

Notice patrol: two variables $public and $system were generating notices in lib/htmloutputter.php, removed because these two parameters are null by default.

Requested by: Brett Taylor
Status: Merged
Source repository: glutnix:0.8.x-notices-in-htmloutputter
Target repository: mainline:0.8.x
Created at: August 11th, 2009 04:04

Commits that would be merged:

Version 1

Version 1

f2cd83d
d6bcc63

two variables $public and $system were generating notices in lib/htmloutputter.php, removed because these two parameters are null by default.

Showing

Showing f2cd83d-d6bcc63

Comments
Include comments entered inline

→ State changed from Open to Merged

This bug was introduced when candrews started the HTML 5 conversion. I'm not sure it’s a good idea, but it’s probably a good idea not to generate notices. So, I've applied the patch until we figure out our HTML strategy.

Evan Prodromou | 2009-08-11 04:47:39 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/1184

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/statusnet/mainline.git \
  refs/merge-requests/1184

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit 0.8.x..merge-requests/1184

# To apply the changes to your branch:
git checkout 0.8.x
git merge merge-requests/1184
git push origin 0.8.x

Reviewing merge request #1184: Notice patrol: two variables $public and $system were generating notices in...

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline