Reviewing merge request #1801: Fixed app slowdown by commenting out two lines that do nothing

Date.toString causes calls to com.ibm.icu4jni.util.Resources.getTimeZonesNative which runs very slowly (the two lines I commented out represent 97% of the total time used for showing departures list).

With these changes, this application works perfectly on the Android AVD emulator and on my HTC Hero.

Requested by: Simon Skrede
Status: Merged
Source repository: simonskredes-clone:master
Target repository: trafikanten-android:master
Created at: October 14th, 2009 12:56

Commits that would be merged:

Version 1

Version 1

ab3c1ef
491fb0f

Fixed application slowdown when showing departures

Showing

Showing ab3c1ef-491fb0f

Comments
Include comments entered inline

→ State changed from Open to Merged

Wow, great stuff, thanks a million!

I merged your change and published a new version on Market (1.0.4).

Marius Mårnes Mathiesen | 2009-10-14 13:33:01 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/1801

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/trafikanten/trafikanten-android.git \
  refs/merge-requests/1801

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/1801

# To apply the changes to your branch:
git checkout master
git merge merge-requests/1801
git push origin master

Reviewing merge request #1801: Fixed app slowdown by commenting out two lines that do nothing

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline