Reviewing merge request #7: BUGFIX: enable stream song scrobbling

I noticed that streamed songs were being initially submitted to last.fm as "Now Playing" but were never confirmed and scrobbled.

After some research, I realized that the simple addition of duration information to each item info would allow completed scrobbles. This is a simple one-line change to "default.py" file. Additionally, I added a one line log of the song info for debugging purposes.

- Roy Ivy III

Requested by: Roy Ivy III
Status: Closed
Source repository: rivy-xbmc-pandora:master
Target repository: xbmc-pandora:master
Created at: February 5th, 2012 05:06

Commits that would be merged:

Version 1

Version 1

2cf1ae2
8806a99

BUGFIX: Fix stream item info to enable song scrobbling submissions

Showing

Showing 2cf1ae2-8806a99

Comments
Include comments entered inline

Pushed new version 1

Roy Ivy III | 2012-02-05 05:07:26 UTC

→ State changed from Open to Closed

Merged

spbogie | 2012-04-30 01:00:57 UTC

Add a new comment:

Login or create an account to post a comment

How to apply this merge request to your repository

One way to merge in these changes is to pull them into a local branch for review, verifying the changes and then merge to back to master.

# Check out a new branch for integration
git checkout -b merge-requests/7

# Fetch the merge request into this branch
git pull \
  git://gitorious.org/xbmc-pandora/xbmc-pandora.git \
  refs/merge-requests/7

# Show the commits, assess they are okay
git log --pretty=oneline --abbrev-commit master..merge-requests/7

# To apply the changes to your branch:
git checkout master
git merge merge-requests/7
git push origin master

Reviewing merge request #7: BUGFIX: enable stream song scrobbling

Commits that would be merged:

Comments Include comments entered inline

Add a new comment:

Gitorious

Comments
Include comments entered inline