l2tp: fix oops in l2tp_eth_create() error path
authorTom Parkin <tparkin@katalix.com>
Mon, 29 Oct 2012 23:41:48 +0000 (23:41 +0000)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 17 Nov 2012 21:16:18 +0000 (13:16 -0800)
commit988aaa6d344cdd838db420919dc26b3c0248e65a
treece7c5b0844149c44960a24320df8f3fd1bbe4a01
parent808235fefa3de34ff292cc86b0edfad17a6f056e
l2tp: fix oops in l2tp_eth_create() error path

[ Upstream commit 789336360e0a2aeb9750c16ab704a02cbe035e9e ]

When creating an L2TPv3 Ethernet session, if register_netdev() should fail for
any reason (for example, automatic naming for "l2tpeth%d" interfaces hits the
32k-interface limit), the netdev is freed in the error path.  However, the
l2tp_eth_sess structure's dev pointer is left uncleared, and this results in
l2tp_eth_delete() then attempting to unregister the same netdev later in the
session teardown.  This results in an oops.

To avoid this, clear the session dev pointer in the error path.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
net/l2tp/l2tp_eth.c