5 years agoDo not force SSE2 instructions on i386 builds v5.2.0
Allan Sandfeld Jensen [Tue, 26 Nov 2013 09:17:44 +0000 (10:17 +0100)]
Do not force SSE2 instructions on i386 builds

To have consistent rendering between x86 and x64 builds QtWebKit enables
SSE2 math on x86. This however raises the minimum requirements of the x86
binaries and should be disabled in Qt builds.

Change-Id: If57ff0a3c9cd0a91a508ba02fda8b596381262a8
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoAccount for when the QGraphicsView is a top level widget v5.2.0-rc1
Andy Shaw [Mon, 25 Nov 2013 10:31:51 +0000 (11:31 +0100)]
Account for when the QGraphicsView is a top level widget

When the QGraphicsView was a top level widget then it would not account
for the transformations as it did not translate the point from the scene
to the view.

[ChangeLog][QtWebKitWidgets][QGraphicsWebView] Make sure that mouse
events for QGraphicsWebView items in a top level QGraphicsView.
Task-number: QTBUG-32179

Change-Id: I2c26580a7e7e5eaec08d71768298e961d3e9d13b
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoWebKitQML examples does not work on Mac
Allan Sandfeld Jensen [Fri, 22 Nov 2013 17:18:10 +0000 (18:18 +0100)]
WebKitQML examples does not work on Mac

A combination of a flawed GCC 4.2 implementation and a compiler
misdetection that meant it was also used for clang caused WebKitQML
to crash on startup.

Task-number: QTBUG-35040
Change-Id: I77534c0e9974a79e7487d5211b1374b250219d49
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoDoc: Fix issues in Qt WebKit documentation config file
Topi Reinio [Wed, 20 Nov 2013 14:20:16 +0000 (15:20 +0100)]
Doc: Fix issues in Qt WebKit documentation config file

This change addresses following issues:
    - Replace hard-coded version strings with QT_VERSION et al.
    - Use the word 'Reference' in description for consistency
    - Add a url variable
    - Add a filter for Qt WebKit (usable in Qt Creator Help)
    - Use the correct selector for listing QML types

Task-number: QTBUG-34966
Change-Id: Ic8f404720b02e022da964eadd50cbd140482809c
Reviewed-by: Jerome Pasion <jerome.pasion@digia.com>
5 years agoDetach image data when returning an ImageFrame as a native image.
Michael Brüning [Thu, 21 Nov 2013 16:22:21 +0000 (17:22 +0100)]
Detach image data when returning an ImageFrame as a native image.

With error analysis and fixing guidance by Allan Sandfeld Jensen.

This caused crashes when a gif was being loaded and the data in the
backing store for image frame was prematurely freed.

Task-number: QTBUG-31936
Change-Id: I7f4454db00cbbcf53f18060aa986a843c7522d57
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoFix compilation on ARM
Samuli Piippo [Mon, 18 Nov 2013 11:51:46 +0000 (13:51 +0200)]
Fix compilation on ARM

Android fix broke ARM compilation on non-Android Linux platforms.
Now correcly define Elf32_auxv_t only on Android/Qt and otherwise
include asm/hwcap.h

Same fix was previously applied to QtScript, which had the exact
same android problem (QTBUG-30978).

Task-number: QTBUG-34917
Change-Id: I29d570731754c6291f8dc0c379e6fdc8ec72b897
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix left-over reference to qtlocation
Allan Sandfeld Jensen [Wed, 13 Nov 2013 14:30:52 +0000 (15:30 +0100)]
Fix left-over reference to qtlocation

QtWebKitWidgets were still incorrectly looking for the qtlocation module
instead of the qtpositioning module.

Change-Id: I3945a6d73e8438dadde05055c082ee3f4f39cdc6
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoFix crash when converting QObjectList
Allan Sandfeld Jensen [Tue, 12 Nov 2013 15:26:32 +0000 (16:26 +0100)]
Fix crash when converting QObjectList

We were passing on a PassRefPtr to multiple lower calls, since any
conversion from a PassRefPtr to a RefPtr will reset the PassRefPtr to
null, it should not be used for multiple calls.

Task-number: QTBUG-34278
Change-Id: I8d4bf28e25eb6e66baef38e0352c40a08f504538
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoFix MSVC2013 compilation
Yuchen Deng [Tue, 12 Nov 2013 13:51:34 +0000 (21:51 +0800)]
Fix MSVC2013 compilation

Starting with MSVC 2013, more functions are provided.

Task-number: QTBUG-34705

Change-Id: I90bf939ad4503a00d31e81c148c6b4ef8af6caff
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoAdd padding objects for classes with netscape plugin api conditionals.
Michael Brüning [Thu, 14 Nov 2013 17:49:17 +0000 (18:49 +0100)]
Add padding objects for classes with netscape plugin api conditionals.

When building with the Visual Studio Compiler on windows, we are facing
some problems because objects that are shared between WebKit1 and
WebKit2 have different memory maps for inlined accessors because the
Netscape Plugin API had to be disabled for the WebKit2 API on Windows
in the new snapshot for Qt 5.2.

This caused plugins not to be loaded because the wrong values for the
mime types and urls are returned and might lead to all kinds of bugs and

This patch adds dummy pointers / data structures for the parts of the
build that do not have the Netscape Plugin API enabled.

Task-number: QTBUG-34280
Change-Id: Iaa2cd2b19d07eff71981f392d913ae5218495266
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
Reviewed-by: Michael Bruning <michael.bruning@digia.com>
5 years agoTrigger layout after resizing the FrameView.
Michael Brüning [Wed, 13 Nov 2013 17:13:36 +0000 (18:13 +0100)]
Trigger layout after resizing the FrameView.

There are problems with QGLWidget based web plugins due to the fact
that WebKit forces us to relayout during paint events, which in turn
might resize widgets, causing the shared backing store's QImages to
be corrupted and hence causing crashed.

This patch triggers a layout upon resizing the FrameView, which reduces
the likely hood of resizing plugins during a subsequent paintEvent.

Task-number: QTBUG-34277
Change-Id: Id35c72a3cc68ac6633a74fba0669c2d8fbfabc88
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix fullscreen support with GStreamer
Allan Sandfeld Jensen [Mon, 4 Nov 2013 14:43:23 +0000 (15:43 +0100)]
Fix fullscreen support with GStreamer

Fullscreen support has not been working with GStreamer since Qt 4.8,
the issue was the native fullscreen window was not fully ported, and
was affected by some bitrot.

This patch fixes the native fullscreen window for GStreamer, ensures the
fullscreen options are available on WebKit1, and adds a context menu and
web action to toggle fullscreen mode.

Change-Id: I9c6c5a1e36fbbc8e1d1fae371bdf9abc1aee7775
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoFix compilation of GraphicsSurfaceMac on OS X 10.9 Mavericks
Eike Ziller [Mon, 4 Nov 2013 16:17:40 +0000 (17:17 +0100)]
Fix compilation of GraphicsSurfaceMac on OS X 10.9 Mavericks

Change-Id: I5c0685b79e653d06073bf3df3e08e1feb3826948
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoDisable QtWebkit for QNX
Andreas Holzammer [Thu, 31 Oct 2013 16:33:37 +0000 (17:33 +0100)]
Disable QtWebkit for QNX

BlackBerry/QNX has the torch webkit.

Change-Id: I3defb065b18fc7e00d6b3bdcfeb79a05fb51e629
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix ABI violation in QWebSettings::CSSCompositingEnabled
Allan Sandfeld Jensen [Thu, 31 Oct 2013 12:36:07 +0000 (13:36 +0100)]
Fix ABI violation in QWebSettings::CSSCompositingEnabled

QWebSettings::CSSCompositingEnabled was added in the middle of the enum
instead of being put at the end.

Since it controlled a RuntimeEnabledFeatures which are global and does
not work per page like QWebSettings should. The setting has been removed
but kept enabled by default.

Change-Id: I5dc35eee78c3846c8482e044c6dd5cd34410969c
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoRemove unused runtime enabled features
Allan Sandfeld Jensen [Wed, 30 Oct 2013 15:53:18 +0000 (16:53 +0100)]
Remove unused runtime enabled features

Reverts the addition of CanvasPathEnabled setting. It had no effect since
it only changed the unused RuntimeEnabledFeatures.

WebKit ChangeLog:

Some of the runtime enabled features were only ever used by the V8 bindings
and can be removed as no WebKit code sets or reads them.

* bindings/generic/RuntimeEnabledFeatures.cpp:
* bindings/generic/RuntimeEnabledFeatures.h:

Change-Id: Ie15d05d6e27e5edb62cc5ce00fd59258df8ec2d7
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoProspective build fix for builds with video disabled
Simon Hausmann [Wed, 30 Oct 2013 08:08:05 +0000 (09:08 +0100)]
Prospective build fix for builds with video disabled

Change-Id: I65f8b063cdac252941d2e4dd91bd2a367b101cbc
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoSupport HTML5 media context menu items
Allan Sandfeld Jensen [Tue, 15 Oct 2013 17:00:43 +0000 (19:00 +0200)]
Support HTML5 media context menu items

Support most of the items WebCore populates the context menu with when
the user right clicks an HTML5 audio or video element.

Change-Id: I331a3271f68075fe70d914e2675620f617d53b42
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoLoad libudev at run-time
Allan Sandfeld Jensen [Fri, 25 Oct 2013 10:49:25 +0000 (12:49 +0200)]
Load libudev at run-time

Changes the usage of libudev from linking at compile time to loading at

Task-number: QTBUG-34176
Change-Id: I7feb91ed3ee1c21dbb3ab508cb7ad6d69c73cc01
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoRedisable debug-info on MinGW64
Allan Sandfeld Jensen [Thu, 24 Oct 2013 12:05:21 +0000 (14:05 +0200)]
Redisable debug-info on MinGW64

Change f6069ba2adac13eee941a300595aa3c0a445fc1a disabled the stripping
of debug information from linux x64 builds, but accidentally also
disabled it for MinGW64 builds.

This patch ensures we again strip the deeper WebKit debug information
from all win32-g++ builds

Change-Id: I06e2a85f71cb159205a0e9acae01806ecf4e6b0f
Reviewed-by: Jonathan Liu <net147@gmail.com>
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoOnly use 64bit atomics when supported
Allan Sandfeld Jensen [Wed, 23 Oct 2013 12:24:27 +0000 (14:24 +0200)]
Only use 64bit atomics when supported

To support Windows XP we must avoid using the 64bit variants of the
atomicIncrement/atomicDecrement operations which are only supported from
Windows 2003 and up.

This patch rolls back the minimum Win32 API version to WinNT 5.1 (32bit WinXP),
and adds a new flag to indicate the support of 64bit atomics.

The new flag is now also used to support MIPS and other architectures
without 64bit intrinsics, instead of hacking in poor support.

This also extends the atomic operations to sparc64 which was previously
skipped because it did not work with __exchange_and_add.

Task-number: QTBUG-34271
Change-Id: I21b09df3cafb7f0987a2f44c89036ff34ed34aa0
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
Reviewed-by: Kai Koehne <kai.koehne@digia.com>
5 years agoASSERTION FAILED: !node || node->isShadowRoot() in WebCore::EventRetargeter::eventTar...
Ryosuke Niwa [Tue, 22 Oct 2013 13:35:15 +0000 (15:35 +0200)]
ASSERTION FAILED: !node || node->isShadowRoot() in WebCore::EventRetargeter::eventTargetRespectingTargetRules


Reviewed by Andy Estes.

Merge https://chromium.googlesource.com/chromium/blink/+/4ce9bfbf54410179cd0f18b3d1a912045fc0ec3d

* dom/EventRetargeter.h:

Change-Id: I56a3429e72689e58e744895b2f85cbcea20e7f54
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154289 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoFix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist
Ryosuke Niwa [Tue, 22 Oct 2013 13:34:25 +0000 (15:34 +0200)]
Fix NULL de-refernce in HTMLAnchorElement::sendPings when settings doesn't exist


Reviewed by Darin Adler.

Merge https://chromium.googlesource.com/chromium/blink/+/d5783da353ab783e9994b8fbecd91880be5192a1

No new tests since the test in the Blink change doesn't reproduce crash on WebKit.

* html/HTMLAnchorElement.cpp:

Change-Id: I3776e3d96013e9f71adfa9942c941040326c6b73
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153975 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoFix build for boot2qt eAndroid
Allan Sandfeld Jensen [Fri, 18 Oct 2013 16:14:17 +0000 (18:14 +0200)]
Fix build for boot2qt eAndroid

Reverts the removal of Android support in WTF, and brings the support
up to date.

Merged change to MacroAssemblerARM.cpp from QtScript.

Replaces use of statvfs with statfs in one place.

Replaces shm-based shared memory with ashmem-based in WebKit2.

Change-Id: I440b1fbd94bb4148f7ba764d77de65230d13ed90
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoUse global Qt configuration for libudev v5.2.0-beta1
Allan Sandfeld Jensen [Mon, 21 Oct 2013 11:36:02 +0000 (13:36 +0200)]
Use global Qt configuration for libudev

Only build WebKit with libudev dependency if Qt was configured with libudev.

Task-number: QTBUG-34176
Change-Id: Iaabb2401e2dc4a91d46a5e4f759546e0de278a08
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoUpdate configure warnings
Allan Sandfeld Jensen [Mon, 21 Oct 2013 10:28:08 +0000 (12:28 +0200)]
Update configure warnings

The configure warnings issued by Qt WebKit are slightly outdated. This
updates then to be more accurate to what caused the failure and where
it can be fixes.

Change-Id: Iec41c20c86787dd95c8cb209604747587e7931bc
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoBuild improvements
Allan Sandfeld Jensen [Mon, 21 Oct 2013 09:31:15 +0000 (11:31 +0200)]
Build improvements

Do not try to compile headers files, this fails on some systems.

Disable C++11 compat warnings on non-linux unix based systems.

Change-Id: I02457db61a61068261d2717eee74f58bdf496f58
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years ago[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.
Julien Brianceau [Wed, 16 Oct 2013 14:07:42 +0000 (16:07 +0200)]
[sh4] Jump over maxJumpReplacementSize in revertJumpToMove.


Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-07
Reviewed by Oliver Hunt.

Jump over maxJumpReplacementSize in revertJumpToMove, even if there is no constant
value within the area. This patch fixes debug ASSERTs failures for sh4 architecture.

* assembler/SH4Assembler.h:

Change-Id: Ice297393b167eace620ace8d8957014f0b3945c8
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157046 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp.
Julien Brianceau [Wed, 16 Oct 2013 14:04:05 +0000 (16:04 +0200)]
[arm] Inverted src and dest FP registers in DFG speculative JIT when using hardfp.


Patch by Julien Brianceau <jbriance@cisco.com> on 2013-10-09
Reviewed by Michael Saboff.

* dfg/DFGSpeculativeJIT.h:

Change-Id: Ib633513948031702efd5ca0d4b89920e99979755
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@157173 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoSVG stroke-dasharray not working
Allan Sandfeld Jensen [Thu, 17 Oct 2013 13:51:24 +0000 (15:51 +0200)]
SVG stroke-dasharray not working

When creating the QPainterPathStroker we forget to also copy the dashPattern property.

Task-number: QTBUG-34063
Change-Id: Idb4d124447e2727c418c8ca5e1de694245f6ba22
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoRevert r152209
Allan Sandfeld Jensen [Thu, 17 Oct 2013 12:00:45 +0000 (14:00 +0200)]
Revert r152209

Revert another fixup patch for one of the commits we reverted in our branch.

Change-Id: I423969481d398df7f334ba4fbf2f2e466ff418fb
Reviewed-by: Julien Brianceau <jbriance@cisco.com>
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years ago32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state
Mark Hahnenberg [Wed, 16 Oct 2013 14:01:27 +0000 (16:01 +0200)]
32-bit code gen for TypeOf doesn't properly update the AbstractInterpreter state


Reviewed by Geoffrey Garen.

It uses a speculationCheck where it should be using a DFG_TYPE_CHECK like the 64-bit backend does.
This was causing crashes on maps.google.com in 32-bit debug builds.

* dfg/DFGSpeculativeJIT32_64.cpp:

Change-Id: Icdcfe0719d22df7db6dc7ffcee309b75b63914df
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153793 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoFix undefined reference linker errors with MinGW
Kai Koehne [Tue, 15 Oct 2013 14:48:14 +0000 (16:48 +0200)]
Fix undefined reference linker errors with MinGW

Make sure the inline methods are defined whereever referenced. This fixes
'undefined reference' errors when linking with MinGW-builds 4.8.2 32 bit
posix dwarf rev2.

Task-number: QTBUG-34083
Change-Id: Iadc7300634780741be9d97bc889290cd113181e1
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoMissing QWebSettings
Allan Sandfeld Jensen [Tue, 15 Oct 2013 09:17:50 +0000 (11:17 +0200)]
Missing QWebSettings

We have enabled the Canvas Path Object as compile-time feature, but
being disabled by default we give the user no way of using it.

CSS Grid layout is also disabled by default, but is already exposed but
not documented.

Change-Id: Ie7a7ac4c2ad24978ed83996ac37327acb2870fe0
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoDefine use_glib in features.prf
Allan Sandfeld Jensen [Mon, 14 Oct 2013 13:37:21 +0000 (15:37 +0200)]
Define use_glib in features.prf

When we use GStreamer we need to define USE(GLIB), we currently do this
separately in WTF and WebCore. This should instead be done centrally to
make the it consistent.

Change-Id: I079dbeaf99b091ea2ecd093bfef1428d963f8300
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoREGRESSION (r149928): CanvasStyle::operator= leaks everything
Alexey Proskuryakov [Mon, 14 Oct 2013 10:11:23 +0000 (12:11 +0200)]
REGRESSION (r149928): CanvasStyle::operator= leaks everything


Reviewed by Andreas Kling.

* html/canvas/CanvasStyle.cpp: (WebCore::CanvasStyle::operator=): Don't leak.

Change-Id: I422e07ff97b04c3cd57fdfc437ae12b56ddfedf7
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156099 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoFix build with GStreamer on non-linux X11 platforms
Allan Sandfeld Jensen [Mon, 14 Oct 2013 10:28:21 +0000 (12:28 +0200)]
Fix build with GStreamer on non-linux X11 platforms

We detect GStreamer based on pkgconfig, this means it is not limited
to linux only, and we need to enable the same features everywhere it
is enabled.

Change-Id: I1b863c663e24f157c3f2d88548dc8c674dd63867
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoImprove backtraces on linux 64bit
Allan Sandfeld Jensen [Mon, 14 Oct 2013 10:21:08 +0000 (12:21 +0200)]
Improve backtraces on linux 64bit

On linux builds we force most debug symbols off in the WTF, JavaScriptCore
and WebCore submodules of QtWebKit. We do this to make linking possible
on 32bit but results in very poor backtraces from our users.

Since this is only needed on 32bit, we should disable it on 64bit.

Change-Id: I5009bb254471dc2213569b0cd011f283d6edfb95
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoEnable more AllInOne files
Allan Sandfeld Jensen [Fri, 11 Oct 2013 16:26:59 +0000 (18:26 +0200)]
Enable more AllInOne files

Fix MediaAllInOne and JSBindingsAllInOne by removing the sources from
them that breaks the rest of the sources.

This should further reduce memory consumption when linking on Windows.

Change-Id: I44e8f134c70b7610947d59b1b51b84ad53241d94
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoRemove unused WebKit2QML library
Allan Sandfeld Jensen [Fri, 11 Oct 2013 15:04:41 +0000 (17:04 +0200)]
Remove unused WebKit2QML library

This library was introduced after Qt 5.1 as a transition to only using
WebKit2's C API. The transition was never completed and the WebKit2QML
library currently only contains one file and serves no purpose.

Change-Id: Iaa2cc0db5504c957065952b693fc68c8fcb84176
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years ago[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange
Renata Hodovan [Fri, 11 Oct 2013 15:10:20 +0000 (17:10 +0200)]
[Qt] SHOULD NEVER BE REACHED is touched WebCore::InputType::createStepRange


Non-steppable input types must not rendered as slider even if its webkit-apperance style
property is set to slider-vertical/horizontal.

Test: platform/qt/fast/forms/range/slider-crash-on-input.html

* platform/qt/RenderThemeQStyle.cpp:

Change-Id: I8428f62d4b0ec92f8cec0ecd0304feda5c1dc13a
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155651 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoEnable more AllInOne files
Allan Sandfeld Jensen [Fri, 11 Oct 2013 12:21:55 +0000 (14:21 +0200)]
Enable more AllInOne files

Modified DOMAllInOne to work on Windows (without libXML2) and enabled
CSSAllInOne which already worked.

This should lower memory pressure when linking on Windows x86.

Change-Id: I621814f44cc8e0aad4cf822d5f0d52c53a6557e2
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoWarning on starting WebProcess
Allan Sandfeld Jensen [Thu, 10 Oct 2013 15:13:08 +0000 (17:13 +0200)]
Warning on starting WebProcess

The localStorageDirectory is set right after the WebContext is created,
but during creation the path is empty and will cause a warning in QDir.

Task-number: QTBUG-33866
Change-Id: I940e08c217ee2401e326bf60910bc628add2f30b
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoRevert "Fix debug builds for Windows32 x86 bots."
Zeno Albisser [Wed, 9 Oct 2013 12:22:52 +0000 (14:22 +0200)]
Revert "Fix debug builds for Windows32 x86 bots."

This reverts commit 7d9d4f0dfe7fe6cab21c4dd45d2e86e7c49ed20a.

While this fixes the issue of running out of memory for linking
32bit debug builds on windows, it seems to introduce various problems
due to mixing debug and non-debug flags within the same binary.

Change-Id: I8836ffe4b4be61b652aae1bc3ce87246aef6e581
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoFix linux-clang with clang 3.4
Allan Sandfeld Jensen [Fri, 4 Oct 2013 14:09:39 +0000 (16:09 +0200)]
Fix linux-clang with clang 3.4

Cherry-picked upstream r153965 to fix linux build with clang 3.4

Change-Id: Ib3eeb5c424c4f0ef00c228ad02b61ef87dd9b3b6
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoCrash on GeoLocation demo
Allan Sandfeld Jensen [Wed, 2 Oct 2013 15:51:06 +0000 (17:51 +0200)]
Crash on GeoLocation demo

Apply missing QtLocation -> QtPositioning renaming.
This was causing GeoLocationController to never be set.

Change-Id: Id6b110ee2df3047b11e1c13ff5a1d2eb9d8b4c40
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix debug builds for Windows32 x86 bots.
Michael Brüning [Fri, 27 Sep 2013 12:19:15 +0000 (14:19 +0200)]
Fix debug builds for Windows32 x86 bots.

Reviewed by Allan Sandfeld Jensen.

There was an out of memory problem when linking the debug builds
that had been solved on Linux and MinGW32 already by stripping
debug info from production builds.

This patch applies the same for MSVC builds on x86 hosts and enable the
debug symbols again for builds running on x86_64 hosts.

Change-Id: Id9ead480f243d8e48494f350a7a96b2bd2570c95
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[sh4] Missing instruction in nativeCallTrampoline LLINT function.
Julien Brianceau [Fri, 4 Oct 2013 10:11:32 +0000 (12:11 +0200)]
[sh4] Missing instruction in nativeCallTrampoline LLINT function.

"move t0, a0" is missing in sh4 implementation of nativeCallTrampoline.
Reuse MIPS implementation to avoid code duplication.
Fixed in changeset 153371 of WebKit trunk.

Change-Id: Ifcc729006bcb426a797762aab093cd300401633c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[Texmap] CSS filter not working on software composited layers
Allan Sandfeld Jensen [Tue, 1 Oct 2013 15:10:19 +0000 (17:10 +0200)]
[Texmap] CSS filter not working on software composited layers


Reviewed by Noam Rosenthal.

Tell the rendering layer we do not support CSS filters when we do not. This
will make RenderLayer fall back to using its own software implementation.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
* platform/graphics/texmap/TextureMapperImageBuffer.cpp:

Change-Id: I89b033c30ea507a79861443afc96d56374c6fea5
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156710 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoSupport kerning with SVG web fonts
Allan Sandfeld Jensen [Fri, 27 Sep 2013 12:45:02 +0000 (14:45 +0200)]
Support kerning with SVG web fonts


Reviewed by Stephen Chenney.

Adds the glue to WidthIterator to take advantage of kerning in SVG web fonts.
To supply SVG font kerning with its required text input, the signature of
applyFontTransforms has been extended.

Since SVG font kerning was extremely slow, it has been sped up by replacing
the iteration over all possible kerning definitions with a hash-map based
lookup of the leading symbol to be kerned. The new algorithm provides a
roughly 100x speed-up in SVG font kerning.

Test: fast/text/svg-font-face-with-kerning.html

* platform/graphics/TextRun.h:
* platform/graphics/WidthIterator.cpp:
* rendering/svg/SVGTextRunRenderingContext.cpp:
* rendering/svg/SVGTextRunRenderingContext.h:
* svg/SVGFontElement.cpp:
* svg/SVGFontElement.h:
* svg/SVGHKernElement.cpp:
* svg/SVGHKernElement.h:
* svg/SVGVKernElement.cpp:
* svg/SVGVKernElement.h:

Change-Id: I309d05b57df3a85fa9720e56f4ace53d5d1d8cf5
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156393 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoDoc: Reverted name of Qt WebKit and landing page filename.
Jerome Pasion [Mon, 30 Sep 2013 13:36:33 +0000 (15:36 +0200)]
Doc: Reverted name of Qt WebKit and landing page filename.

-qtwebkit-index.html and "Qt WebKit" are the correct names for the
module according to the writing guidelines
-index.html will collide with the main Qt 5 index.html page

Change-Id: Ic07ae422b85766090b1e3c09b34100293a972bfb
Reviewed-by: Martin Smith <martin.smith@digia.com>
5 years ago[Qt] Fix build with Qt 5.2 QtPosition module
Allan Sandfeld Jensen [Fri, 27 Sep 2013 12:50:22 +0000 (14:50 +0200)]
[Qt] Fix build with Qt 5.2 QtPosition module


Reviewed by Simon Hausmann.


QtLocation -> QtPositioning

* Source/sync.profile:


QtLocation -> QtPositioning

* WebKit1.pri:


QtLocation -> QtPositioning

* WebCoreSupport/GeolocationClientQt.cpp:


QtLocation -> QtPositioning

* Target.pri:
* UIProcess/qt/WebGeolocationProviderQt.cpp:
* WebKit2.pri:


QtLocation -> QtPositioning. Make sure we set build type before doing configure checks
that might depend on them.

* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:

Change-Id: I96a16559373a21513c4d83e53b6cee9f27682649
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156395 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[Qt] RepaintRequested signal sometimes not emitted
Allan Sandfeld Jensen [Thu, 26 Sep 2013 11:38:34 +0000 (13:38 +0200)]
[Qt] RepaintRequested signal sometimes not emitted


Reviewed by Simon Hausmann.

We should also emit repaintRequested after calling PageClient::update().

* WidgetSupport/PageClientQt.cpp:

Change-Id: Ib8664ef0b25b7b9c51f3fd32925d018be3906299
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156329 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[Qt] Crash when trying to download blob url
Allan Sandfeld Jensen [Thu, 26 Sep 2013 11:34:48 +0000 (13:34 +0200)]
[Qt] Crash when trying to download blob url


Reviewed by Simon Hausmann.


Resolve any blob URLs before creating a QUrl.

* platform/network/qt/ResourceRequestQt.cpp:


Do not crash if a download was triggered on a resource WebCore handles internally.

* WebCoreSupport/FrameLoaderClientQt.cpp:

Change-Id: I9191eb991be81f69df4328ab54132da3dde15241
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156330 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoRevert "Un-crashify JSC tests on debug bots after Anders had his way with StringImpl." v5.2.0-alpha1
Allan Sandfeld Jensen [Tue, 24 Sep 2013 16:33:25 +0000 (18:33 +0200)]
Revert "Un-crashify JSC tests on debug bots after Anders had his way with StringImpl."

Revert another commit that depended on the reverted SQLite commit.

Change-Id: I629b6ab7822c15f9f61f61cd880edefd9545838b
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix build on OS X 10.6
Allan Sandfeld Jensen [Wed, 18 Sep 2013 11:58:50 +0000 (13:58 +0200)]
Fix build on OS X 10.6

The assembler on older Mac's is buggy and requires 'movd' instructions
instead of 'movq' on x64. This is worked around in newer GCCs, but for
older ones it is easier to just not build LLint.

Do not use automatic conversion of Function<> to BLOCK.

Change-Id: I623c91acc79cd3476c441e1c981a2152de05d00c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[Qt] Update sync.profile https://bugs.webkit.org/show_bug.cgi?id=121295
Allan Sandfeld Jensen [Fri, 20 Sep 2013 13:01:57 +0000 (15:01 +0200)]
[Qt] Update sync.profile https://bugs.webkit.org/show_bug.cgi?id=121295

Reviewed by Simon Hausmann.

Ensure we let the dependencies pick the right branch instead of always
master and list all the dependencies we need on all platforms.

* Source/sync.profile:

Change-Id: Ia6f2d55911eb18c4ecacac017439afe78db5f17c
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix build with MingW
Allan Sandfeld Jensen [Wed, 18 Sep 2013 16:14:04 +0000 (18:14 +0200)]
Fix build with MingW

Fix wrong export/import flags in inlined methods.

Use normal GCC inline asm instead of _ReadWriteBarrier.

Change-Id: Iba6b923be383777f2807d84349044dbe5a22eb57
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoMerge branch 'stable' into dev
Sergio Ahumada [Thu, 19 Sep 2013 21:41:33 +0000 (23:41 +0200)]
Merge branch 'stable' into dev


Change-Id: I0961de8127cf1c8233036038a324c2567a70533e

5 years agoSkip build on OS X 10.6 and Windows MingW temporarily
Allan Sandfeld Jensen [Thu, 19 Sep 2013 11:59:07 +0000 (13:59 +0200)]
Skip build on OS X 10.6 and Windows MingW temporarily

Skip the build on the most quirky platforms until the rest of the merge
has landed.

Change-Id: I9813fef570fffde4de51b66e9e15ba04e44cd0c3
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoQtWebKit should not require SQLite version to 3.6.16.
Allan Sandfeld Jensen [Wed, 18 Sep 2013 12:56:50 +0000 (14:56 +0200)]
QtWebKit should not require SQLite version to 3.6.16.

Revert r152134 which raised the minimum SQLite version,
and r152201 which removed a method the reverted code needed.

Change-Id: Ie028992137f3983d114f3491423afe6303173544
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoRemove C++11 requirement in WebKit2
Allan Sandfeld Jensen [Tue, 17 Sep 2013 09:01:33 +0000 (11:01 +0200)]
Remove C++11 requirement in WebKit2

Removes all use of C++11 specific features in WebKit2. This consists of
template<S<T>> syntax, a few uses of auto, and a single use of std::move.

Change-Id: I1bbd356c430802caf5f7440cd0d3bb2ba49ed098
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix build with clang
Allan Sandfeld Jensen [Fri, 13 Sep 2013 16:59:49 +0000 (18:59 +0200)]
Fix build with clang

Forcing C++11 on clang does not work on older versions of clang. Instead
fix https://bugs.webkit.org/show_bug.cgi?id=115741 by disabling rvalue
references if clang is using a too old version of libstdc++11.

Avoid compile_asserts unless we have the same C++11 static asserts used in trunk.

Finally build ANGLE with the same C++11 state as the rest, otherwise it will expect
libstdc++ symbols instead of libc++ symbols.

Change-Id: Ifa49325a73d6dc17bc67bccd79813b25860df915
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix build with namespaced Qt
Allan Sandfeld Jensen [Fri, 13 Sep 2013 15:35:03 +0000 (17:35 +0200)]
Fix build with namespaced Qt

One forward declaration of QUrl was missing proper namespace macros.

Change-Id: Ibb2414b63e2926015874b4cf7024f101d59be6dc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoFix build with gcc 4.4
Allan Sandfeld Jensen [Fri, 13 Sep 2013 14:29:33 +0000 (16:29 +0200)]
Fix build with gcc 4.4

Nullptr is one of the C++11 features not fully supported in gcc 4.4,
we can therefore not rely on it being converted to a pointer automatically.

Change-Id: I91830a2e78d9eb7532930581774cc095181cbf83
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoImport Qt5x2 branch of QtWebkit for Qt 5.2
Allan Sandfeld Jensen [Fri, 13 Sep 2013 10:51:20 +0000 (12:51 +0200)]
Import Qt5x2 branch of QtWebkit for Qt 5.2

Importing a new snapshot of webkit.

Change-Id: I2d01ad12cdc8af8cb015387641120a9d7ea5f10c
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoUpdate location of qaccessiblewidget.h
Allan Sandfeld Jensen [Thu, 19 Sep 2013 15:43:47 +0000 (17:43 +0200)]
Update location of qaccessiblewidget.h

The definition of QAccessibleWidget has moved again.

Change-Id: Ibeebdd236d5a5d40e4e811975524e5c3c5ee0673
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoCorrect range used for Emoji checks. old/5.1
Michael Brüning [Tue, 17 Sep 2013 13:31:35 +0000 (15:31 +0200)]
Correct range used for Emoji checks.


Reviewed by Allan Sandfeld Jensen.

Found and reported by David Binderman via Qt bug tracker.

The check if a character was in the Emoji range always evaluated to
false due to the upper range limit being lower than the lower limit.

Changed the upper limit to the highest assigned character from the
"Transport and Map Symbols" (0x1F6C5) as that seems to have been the
intended upper range limit of this check.

* platform/graphics/Font.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155951 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: Ie62aceb17bba170b0191ba64434e17d445cf7779
Task-number: QTBUG-33206
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years agoMerge branch 'stable' into dev
Sergio Ahumada [Fri, 13 Sep 2013 16:29:33 +0000 (18:29 +0200)]
Merge branch 'stable' into dev


Change-Id: Iaa6209d0d611d18b8c916bcd165c8bf5b7441b7b

5 years agoJSC ARM traditional failing on Octane NavierStokes test
Gabor Rapcsanyi [Tue, 10 Sep 2013 14:13:54 +0000 (16:13 +0200)]
JSC ARM traditional failing on Octane NavierStokes test


Reviewed by Zoltan Herczeg.

Change the ARM traditional assembler to use double precision on value

* assembler/ARMAssembler.h:

Change-Id: I2fbf6323a59120b497215696e10a1582ff927347
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@149601 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Use correct library paths for prefix builds on Mac.
Michael Brüning [Wed, 4 Sep 2013 10:59:52 +0000 (12:59 +0200)]
[Qt] Use correct library paths for prefix builds on Mac.


Reviewed by Tor Arne Vestbø.

Due to a change of scope of the qmake force_independent configuration
flag, the library paths in QtWebKit builds on the Mac are set to the
QtWebKit build directory even for production builds.

This patch sets the correct library paths for prefixed production builds
while keeping the scope of the force_independent flag for non-production

* Source/api.pri:
* Source/widgetsapi.pri:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155034 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I2563e5e7f9582128f32bae459df54186ff88fe87
Task-number: QTBUG-32417
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Images scaled poorly on composited canvas
Allan Sandfeld Jensen [Tue, 3 Sep 2013 15:32:55 +0000 (17:32 +0200)]
[Qt] Images scaled poorly on composited canvas


Reviewed by Jocelyn Turcotte.

Explicitly set a imageInterpolationQuality on the TextureMapper, because
InterpolationDefault may be interpreted differently by nested GraphicsContexts.

* WebCoreSupport/TextureMapperLayerClientQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-33081
Change-Id: Iec90f53da38c4520cef2aac0519e36af74dd5a50
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Tiled-backing store not clipped to frame or visible rect
Allan Sandfeld Jensen [Tue, 3 Sep 2013 15:32:19 +0000 (17:32 +0200)]
[Qt] Tiled-backing store not clipped to frame or visible rect


Reviewed by Jocelyn Turcotte.

Clip painting from the tiled-backing store to the frame rect.

* WebCoreSupport/QWebFrameAdapter.cpp:

Change-Id: Ic6947ae8cf58ce597ef82e2f465fc66d5674e0bd
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154983 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Texmap][GTK] The poster-circle doesn't appear.
ChangSeok Oh [Tue, 3 Sep 2013 14:52:42 +0000 (16:52 +0200)]
[Texmap][GTK] The poster-circle doesn't appear.


Patch by ChangSeok Oh <shivamidow@gmail.com> on 2013-01-21
Reviewed by Noam Rosenthal.


We need to call setNeedsDisplay to redraw GraphicsLayer after we set drawsContent
a new value for the layer. Otherwise we can't get a chance for first drawing the layer.

Test: compositing/visibility/visibility-composited-animation.html

* platform/graphics/texmap/TextureMapperLayer.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-33081
Change-Id: Idf95bb5341cc4bc3fdf6d585b52c8b949e3ccb67
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoJavaScriptCore: Fix header guard
Tobias Hunger [Thu, 29 Aug 2013 12:07:31 +0000 (14:07 +0200)]
JavaScriptCore: Fix header guard

Clang nags about it.

Change-Id: I0f4629048e2e02370202cf47748be05bfa0cbf81
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Restore URL Scheme Delegates after QtWebProcess crash
Milian Wolff [Tue, 27 Aug 2013 15:14:18 +0000 (17:14 +0200)]
[Qt] Restore URL Scheme Delegates after QtWebProcess crash


When the QtWebProcess crashes, the registered URL Scheme
Delegates are not properly restored over IPC in the newly
launched process instance.

Reviewed by Simon Hausmann.

* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p_p.h:

Change-Id: I14493ea1190053e5a523d2cf8a99cc8d526b4fd2
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@142997 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Enable QML handling of crashed/unresponsive QtWebProcess
Milian Wolff [Tue, 27 Aug 2013 15:23:41 +0000 (17:23 +0200)]
[Qt] Enable QML handling of crashed/unresponsive QtWebProcess


Forward the processDidCrash, didRelaunchProcess, processDidBecomeUnresponsive
and processDidBecomeResponsive signals to QML's WebView.experimental.

Reviewed by Jocelyn Turcotte.

* UIProcess/API/qt/qquickwebview.cpp:
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:

NOTE: This is the initial iteration of the patch attached to upstream
bug report 108474, i.e.:
The actually committed version is incompatible with the status of
QtWebKit stable as the architecture changed too much.

Change-Id: I91d28dde2774fd1487a96ac36a14b522ffb7756c
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153580 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoMerge "Merge remote-tracking branch 'origin/stable' into dev" into refs/staging/dev
Frederik Gladhorn [Thu, 29 Aug 2013 12:09:21 +0000 (14:09 +0200)]
Merge "Merge remote-tracking branch 'origin/stable' into dev" into refs/staging/dev

5 years ago[Qt] Option key combinations do not work in Input Elements.
Zeno Albisser [Wed, 28 Aug 2013 16:21:37 +0000 (18:21 +0200)]
[Qt] Option key combinations do not work in Input Elements.


Q_WS_MAC is obsolete. We should use Q_OS_MAC instead.
This caused QTBUG-32388.

* WebCoreSupport/EditorClientQt.cpp:

Change-Id: Id884a2da61066e59bf733a83fd47346c270f7b8d
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
Reviewed-by: Pierre Rossi <pierre.rossi@gmail.com>
5 years agoRemove unnecessary dependency to qtjsbackend from sync.profile
Sergio Ahumada [Tue, 27 Aug 2013 15:13:56 +0000 (17:13 +0200)]
Remove unnecessary dependency to qtjsbackend from sync.profile

Change-Id: Ie44654137df36d93fe44f25cb0f78507a9edf532
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoMerge remote-tracking branch 'origin/stable' into dev
Frederik Gladhorn [Tue, 27 Aug 2013 13:38:27 +0000 (15:38 +0200)]
Merge remote-tracking branch 'origin/stable' into dev

Change-Id: I2944629d0ee384b4fdcdb43108ddc2322ba76676

5 years agoFailure building with python3
Laszlo Papp [Tue, 27 Aug 2013 11:36:04 +0000 (13:36 +0200)]
Failure building with python3


Patch by Laszlo Papp <lpapp@kde.org> on 2013-08-23
Reviewed by Benjamin Poulain.

Use print functions instead of python statements to be compatible with python 3.X and 2.7 as well.
Archlinux has been using python3 and that is what causes issues while packaging QtWebKit along with Qt5.

* disassembler/udis86/itab.py:
* disassembler/udis86/ud_opcode.py:
* disassembler/udis86/ud_optable.py:

Change-Id: Icec0024fc39bb342d23bbeefac4de0c81e176e6c
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154521 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Laszlo Papp <lpapp@kde.org>
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoFont's fast code path doesn't handle partial runs correctly when kerning or ligatures...
Allan Sandfeld Jensen [Tue, 27 Aug 2013 11:34:22 +0000 (13:34 +0200)]
Font's fast code path doesn't handle partial runs correctly when kerning or ligatures are enabled


Reviewed by Darin Adler.

Renamed m_characterIndex to m_characterIndexOfGlyph and gave it an inline size of 10,
which covers around 66% of all cases. The rest of the cases are now preallocated to the
upper limit which is length of the original TextRun.

* platform/graphics/FontFastPath.cpp:
* platform/graphics/WidthIterator.cpp:
* platform/graphics/WidthIterator.h:

Change-Id: I253195dc5fc07b4c9d0bb4947cd07d86f054a265
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154674 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoAssertion while scrolling news.google.com
Allan Sandfeld Jensen [Tue, 27 Aug 2013 10:01:11 +0000 (12:01 +0200)]
Assertion while scrolling news.google.com


Reviewed by Anders Carlsson.

Do not relayout when accessing script elements during painting.

* html/HTMLEmbedElement.cpp:

Task-number: QTBUG-30892
Change-Id: Ide884c78dd6a359c0e0de22bb98774d7da90b901
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154672 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoadjust to new MODULE_* variable semantics
Oswald Buddenhagen [Sun, 9 Jun 2013 19:30:54 +0000 (21:30 +0200)]
adjust to new MODULE_* variable semantics

Change-Id: Ida3da49e2df10edf72d9de6b717925bd6c4ac77e
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont
Allan Sandfeld Jensen [Mon, 19 Aug 2013 10:57:44 +0000 (12:57 +0200)]
[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont


Reviewed by Jocelyn Turcotte.

We don't need to allocate FontPlatformData on the heap
since getCachedFontData makes a deep copy anyway.

* platform/graphics/qt/FontCacheQt.cpp:

Change-Id: I02e974e53f36dd01a4b43a21cc98651913c0d515
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154103 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] QtWebKit (using the Arora browser) displays the border radii (radius) of a butto...
Allan Sandfeld Jensen [Mon, 19 Aug 2013 10:44:40 +0000 (12:44 +0200)]
[Qt] QtWebKit (using the Arora browser) displays the border radii (radius) of a button very ugly


Reviewed by Jocelyn Turcotte.

StylePainter::init() was called twice making it clobber the previous antialiasing setting.

This patch cleans up the construction so we only have one constructor with init inlined.

* platform/qt/RenderThemeQStyle.cpp:
* platform/qt/RenderThemeQStyle.h:
* platform/qt/RenderThemeQt.cpp:
* platform/qt/RenderThemeQt.h:
* platform/qt/RenderThemeQtMobile.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTWEBKIt-355
Change-Id: I5f9e50ccc3deeb1ac1c1714c010d766f4ea29908
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoANGLE doesn't build with bison 3.0
Allan Sandfeld Jensen [Fri, 16 Aug 2013 16:27:07 +0000 (18:27 +0200)]
ANGLE doesn't build with bison 3.0


Reviewed by Antti Koivisto.

Make glslang.y compatible with bison 3.0
by using %lex-param to set YYLEX_PARAM.

* src/compiler/glslang.y:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-32913
Change-Id: I15505d31f0588c4d558b73befdb9d2358e29c1a3
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Kerning in fast font path breaks letter-spacing
Allan Sandfeld Jensen [Fri, 16 Aug 2013 16:23:22 +0000 (18:23 +0200)]
[Qt] Kerning in fast font path breaks letter-spacing


Reviewed by Jocelyn Turcotte.


Mark fonts with both kerning and letter-spacing as unsupported by the simple font-path.

Test: fast/text/letter-spacing-kerned.html

* platform/graphics/WidthIterator.h:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-32891
Change-Id: I26ef2b8e3953b7e07f42931a233802644ab586e1
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoMerge remote-tracking branch 'origin/release' into stable
Sergio Ahumada [Thu, 15 Aug 2013 16:14:37 +0000 (18:14 +0200)]
Merge remote-tracking branch 'origin/release' into stable

Change-Id: Id5cb34a6df11467cb5d32b0d5c2dfb921befb45d

5 years agoRevert "[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont" v5.1.1
Allan Sandfeld Jensen [Tue, 13 Aug 2013 12:15:49 +0000 (14:15 +0200)]
Revert "[Qt] memory leak in WebCore::FontCache::getLastResortFallbackFont"

This causes the browser example to crash on startup on 32bit x86.

This reverts commit 25e8da88b2008e62c62206bddc815229761a0fb2
Task-number: QTBUG-32879

Change-Id: I38fb03f7fec5f9a197613d16cc59761b780ec49a
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt][WK2] Composited and transformed links asserts in tap highlight
Allan Sandfeld Jensen [Tue, 13 Aug 2013 10:21:14 +0000 (12:21 +0200)]
[Qt][WK2] Composited and transformed links asserts in tap highlight


Reviewed by Jocelyn Turcotte.

Use a mapping that does not assert when hitting transforms. We still skip
transforms that produces non-rectangular areas.

* page/GestureTapHighlighter.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-32454
Change-Id: I608ed624047dd850c5809cdbbc688ca718add736
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years agoResource leak related to gstreamer and videos
Allan Sandfeld Jensen [Mon, 12 Aug 2013 12:25:25 +0000 (14:25 +0200)]
Resource leak related to gstreamer and videos

MERGE NOTE: Fixes a leak caused by a circular reference between GStreamer
and WebKit, that triggers whenever a page with HTML5 video has been visited
and it fully loaded.


Reviewed by Eric Carlson.

Since active DOM object are only stopped once and can not be restarted, we can
unreference the media player there, instead of waiting for garbage collection.

If the r152778 is rolled back, this also breaks a circular reference between
GStreamer and WebKit which prevented garbage collecting from triggering.

* html/HTMLMediaElement.cpp:

Change-Id: Ie13d202d3cac9b97eb158964b33d492e17f817ef
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153937 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoMerge remote-tracking branch 'origin/stable' into dev
Frederik Gladhorn [Mon, 12 Aug 2013 10:42:20 +0000 (12:42 +0200)]
Merge remote-tracking branch 'origin/stable' into dev

Change-Id: If43a2a4465fc0f236eb3d20d2dc2e2de81955531

5 years agoMerge remote-tracking branch 'origin/release' into stable
Sergio Ahumada [Fri, 9 Aug 2013 20:39:40 +0000 (22:39 +0200)]
Merge remote-tracking branch 'origin/release' into stable

Change-Id: I8b40ab3b0302d45a96c64cf3af34725749f00878

5 years ago[Qt] REGRESSION(r) Two pixel result fail after r153522
Allan Sandfeld Jensen [Fri, 9 Aug 2013 09:15:45 +0000 (11:15 +0200)]
[Qt] REGRESSION(r) Two pixel result fail after r153522


Reviewed by Jocelyn Turcotte.

Consider scaling transform on the painter to determine final destination size.

Covered by existing tests.

* platform/graphics/qt/ImageQt.cpp:

Change-Id: I631e0925abaf814c95f709c18919f127c8b41503
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153790 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Images are down-scaled badly
Allan Sandfeld Jensen [Fri, 9 Aug 2013 09:14:36 +0000 (11:14 +0200)]
[Qt] Images are down-scaled badly


Reviewed by Jocelyn Turcotte.

QPainter only does bilinear filtering, which means it will downscaling beyond
0.5x will start skipping pixel and start to degrade the end result. Scaling in
QImage and QPixmap however uses a better but much more expensive sampling that
counts all pixels.

To get the high quality downscaling we must therefore prescale the images before
painting them. To avoid a performance impact on repeated paints the prescaled
image are saved in the QPixmapCache.

* platform/graphics/qt/ImageQt.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-30155
Change-Id: I8b07de1d7415bc4e2dea565df92739e3ff2014b4
Reviewed-by: Jocelyn Turcotte <jocelyn.turcotte@digia.com>
5 years ago[Qt] Add Page Visibility API support
Benjamin Dupont [Tue, 6 Aug 2013 13:58:39 +0000 (13:58 +0000)]
[Qt] Add Page Visibility API support


Patch by Benjamin Dupont <bdupont@nds.com> on 2013-08-06
Reviewed by Simon Hausmann.

* WebCoreSupport/QWebPageAdapter.cpp:
* WebCoreSupport/QWebPageAdapter.h:
* WidgetApi/qwebpage.cpp:
* WidgetApi/qwebpage.h:
* tests/qwebpage/tst_qwebpage.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

[Qt] Build fix after r153751

Unreviewed build fix.

Fix build when PAGE_VISIBILITY_API is disabled.

* WebCoreSupport/QWebPageAdapter.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153782 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Change-Id: I7c99337a902d7d06cde03107ebf71e3fce430fdf
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>
5 years ago[WK1] NPStream::headers not initialized
Allan Sandfeld Jensen [Fri, 9 Aug 2013 07:59:46 +0000 (09:59 +0200)]
[WK1] NPStream::headers not initialized


Reviewed by Alexey Proskuryakov.

Initialize the header field. According to user feedback that should solve some
cases of random crashes when loading plugins on Mac and Windows.

* plugins/PluginStream.cpp:

git-svn-id: http://svn.webkit.org/repository/webkit/trunk@153828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Task-number: QTBUG-32181
Change-Id: I9ae19b54a1b08615a24a782137285ae4be5ac915
Reviewed-by: Simon Hausmann <simon.hausmann@digia.com>
5 years agoUnprefix Page Visibility API
simon.fraser@apple.com [Sat, 25 May 2013 23:56:01 +0000 (23:56 +0000)]
Unprefix Page Visibility API



Reviewed by Tim Horton.

Remove prefixes from the document properties, and the visibilitychanged event.

Rename the "preview" state to "unloaded". The "unloaded" state is never
reached yet (see https://bugs.webkit.org/show_bug.cgi?id=116769).

Add some comments to places where we should update the visibility state
when going in and out of the page cache, but cannot safely do so yet.

Tested by existing Page Visibility tests.

* dom/Document.cpp:
* dom/Document.h:
* dom/Document.idl:
* dom/EventNames.h:
* history/CachedFrame.cpp:
* loader/FrameLoader.cpp:
* page/Page.cpp:
* page/PageVisibilityState.cpp:
* page/PageVisibilityState.h:


Reviewed by Tim Horton.

Rename "preview" state to "unloaded" state.

* WebCoreSupport/AssertMatchingEnums.cpp:
* ewk/ewk_view.h:


Reviewed by Tim Horton.

Renaming of the "preview" state to "unloaded".

* WebView/WebView.mm:
* WebView/WebViewPrivate.h:


Reviewed by Tim Horton.

Renaming of the "preview" state to "unloaded".

* Shared/API/c/WKPageVisibilityTypes.h:
* Shared/API/c/WKSharedAPICast.h:


Reviewed by Tim Horton.

Rename "preview" state to "unloaded" state, and adjust the tests
to test for it.

* DumpRenderTree/mac/TestRunnerMac.mm:
* TestWebKitAPI/Tests/WebKit2/PageVisibilityState.cpp:
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.html:
* TestWebKitAPI/Tests/mac/PageVisibilityStateWithWindowChanges.mm:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:


Reviewed by Tim Horton.

Remove prefixes, adjust to state name changes.

* fast/events/page-visibility-iframe-delete-test.html:
* fast/events/page-visibility-iframe-move-test-expected.txt:
* fast/events/page-visibility-iframe-move-test.html:
* fast/events/page-visibility-iframe-propagation-test-expected.txt:
* fast/events/page-visibility-iframe-propagation-test.html:
* fast/events/page-visibility-null-view-expected.txt:
* fast/events/page-visibility-null-view.html:
* fast/events/page-visibility-transition-test-expected.txt:
* fast/events/page-visibility-transition-test.html:

Change-Id: I9751efeae0bab8136a63c7e22ad0d513fc8ceb0c
git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150695 268f45cc-cd09-0410-ab3c-d52691b4dbfc
Reviewed-by: Allan Sandfeld Jensen <allan.jensen@digia.com>