Stop unintended re-encoding of author names from UTF-8 to ASCII
authorSebastian Pipping <sebastian@pipping.org>
Wed, 8 May 2013 22:45:27 +0000 (00:45 +0200)
committerTorgny Nyblom <nyblom@kde.org>
Sun, 19 May 2013 06:20:36 +0000 (08:20 +0200)
commit539de0386876ed470f2ae6be90a98421493b3c90
tree5a94b6ae60d52c5398810059dfd43afcae7c4653
parent4a1e11c6ceb17b764c613778d8ce408f0aa28a48
Stop unintended re-encoding of author names from UTF-8 to ASCII

To see the bug in action, use an author map with umlauts, e.g.

nickname = Hällo Wörld from UTF-8 <mail@example.org>

and check "git log" after the conversion.

What is happening?
QByteArray "author" is first decoded as UTF-8 into a QString.
That QString is passed to QByteArray::append(const QString &)
which internally encodes the QString to ASCII byte data using
QString::toAscii().  "git fast-import" expects UTF-8 input
from us, so the original QByteArray with UTF-8 content is just
what we need.
src/repository.cpp