Backport crash fix by Huzaifa Sidhpurwala <huzaifas@redhat.com>
authorHuzaifa Sidhpurwala <huzaifas@redhat.com>
Fri, 28 Jan 2011 06:23:24 +0000 (11:53 +0530)
committerHuzaifa Sidhpurwala <huzaifas@redhat.com>
Fri, 28 Jan 2011 06:23:24 +0000 (11:53 +0530)
commit2dccd0e99fbe17f5df1c2abf9adf3ecc1136cee9
treed2255f5de1e2fd5cf0f36952873f82ed50dcfe75
parent6402d4450a68bd318fee1f589c8855ea163ea391
Backport crash fix by Huzaifa Sidhpurwala <huzaifas@redhat.com>

    2011-01-27  Abhishek Arya  <inferno@chromium.org>

            Reviewed by Dan Bernstein.

            Recalc table sections if needed before calculating the first line
            box baseline.
            https://bugs.webkit.org/show_bug.cgi?id=53265

            When we try to calculate the baseline position of a table cell,
            we recurse through all the child sibling boxes (when children are
            non inline) and add their first linebox baseline values. If one of
            the children is a table with pending section recalc, we will access
            wrong table section values. We recalc table sections if it is needed.

            Test: fast/table/recalc-section-first-body-crash-main.html

            * rendering/RenderTable.cpp:
            (WebCore::RenderTable::firstLineBoxBaseline):
    2011-01-27  Abhishek Arya  <inferno@chromium.org>

            Reviewed by Dan Bernstein.

            Tests that we do not crash when calculating the first line box
            baseline for the table.
            https://bugs.webkit.org/show_bug.cgi?id=53265

            * fast/table/recalc-section-first-body-crash-main-expected.txt: Added.
            * fast/table/recalc-section-first-body-crash-main.html: Added.
            * fast/table/resources/recalc-section-first-body-crash.html: Added.

    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76915 268f45cc-cd09-0410-ab3c-d52691b4dbfc
LayoutTests/fast/table/recalc-section-first-body-crash-main-expected.txt [new file with mode: 0644]
LayoutTests/fast/table/recalc-section-first-body-crash-main.html [new file with mode: 0644]
LayoutTests/fast/table/resources/recalc-section-first-body-crash.html [new file with mode: 0644]
WebCore/rendering/RenderTable.cpp